Sign upLogin

socketio/socket.io

View on GitHub
Star
lib/uws.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function patchAdapter has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function patchAdapter(app /* : TemplatedApp */) {
  Adapter.prototype.addAll = function (id, rooms) {
    const isNew = !this.sids.has(id);
    addAll.call(this, id, rooms);
    const socket: Socket = this.nsp.sockets.get(id);
Severity: Major
Found in lib/uws.ts - About 2 hrs to fix

    Function patchAdapter has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    export function patchAdapter(app /* : TemplatedApp */) {
  Adapter.prototype.addAll = function (id, rooms) {
    const isNew = !this.sids.has(id);
    addAll.call(this, id, rooms);
    const socket: Socket = this.nsp.sockets.get(id);
    Severity: Minor
    Found in lib/uws.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function broadcast has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      Adapter.prototype.broadcast = function (packet, opts) {
    const useFastPublish = opts.rooms.size <= 1 && opts.except!.size === 0;
    if (!useFastPublish) {
      broadcast.call(this, packet, opts);
      return;
    Severity: Minor
    Found in lib/uws.ts - About 1 hr to fix

      Function serveFile has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function serveFile(res /* : HttpResponse */, filepath: string) {
  const { size } = statSync(filepath);
  const readStream = createReadStream(filepath);
  const destroyReadStream = () => !readStream.destroyed && readStream.destroy();
      Severity: Minor
      Found in lib/uws.ts - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status