socketstream/socketstream

View on GitHub

Showing 270 of 270 total issues

Function format has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    format: function(entry, options, formatter,cb, errCb) {
Severity: Minor
Found in lib/client/bundler/proto.js - About 35 mins to fix

    Function exports has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    module.exports = function(ss, messageEmitter, httpServer, config, sessionOptions){
    Severity: Minor
    Found in lib/websocket/transports/engineio/index.js - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        resolvedPath = normalizeArray(filter(resolvedPath.split('/'), function(p) {
            return !!p;
          }), !resolvedAbsolute).join('/');
      Severity: Minor
      Found in lib/client/bundler/browserify.client.js and 1 other location - About 35 mins to fix
      lib/client/bundler/browserify.client.js on lines 236..238

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          path = normalizeArray(filter(path.split('/'), function(p) {
            return !!p;
          }), !isAbsolute).join('/');
      Severity: Minor
      Found in lib/client/bundler/browserify.client.js and 1 other location - About 35 mins to fix
      lib/client/bundler/browserify.client.js on lines 222..224

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function code has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        code: function(nameOrDir, cb) {
          var errorPrefix, onError, onSuccess;
      
          // Strip any leading slash
          if (nameOrDir && nameOrDir.substr(0, 1) === '/') {
      Severity: Minor
      Found in lib/client/system/modules/socketstream.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function alias has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      require.alias = function (from, to) {
          var path = require.modules.path();
          var res = null;
          try {
              res = require.resolve(from + '/package.json', '/');
      Severity: Minor
      Found in lib/client/bundler/browserify.client.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function clientIssue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.clientIssue = function clientIssue(client,options,err,more) {
        var info = [''];
        if (options.serveDebugInfo) {
          err.userInfo = info;
        }
      Severity: Minor
      Found in lib/utils/log.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function readDirSync has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.readDirSync = function(start) {
          var stat,
              found = {dirs: [], files: [] },
              files,
              abspath,
      Severity: Minor
      Found in lib/utils/file.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function exports has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      module.exports = function(ss, router, options) {
      
        function serve(processor) {
          return function(request, response) {
            var path = utils.parseUrl(request.url);
      Severity: Minor
      Found in lib/client/serve/ondemand.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  for (var i = 0; i < encoded.length; i++) {
                    view[i] = encoded.charCodeAt(i);
                  }
      Severity: Minor
      Found in lib/websocket/transports/engineio/client.js and 1 other location - About 35 mins to fix
      lib/websocket/transports/engineio/client.js on lines 2259..2261

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  for (var i = 0; i < p.length; i++) {
                    view[i] = p.charCodeAt(i);
                  }
      Severity: Minor
      Found in lib/websocket/transports/engineio/client.js and 1 other location - About 35 mins to fix
      lib/websocket/transports/engineio/client.js on lines 2298..2300

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  for (var i = 1; i < arguments.length; i++) {
                      args[i - 1] = arguments[i];
                  }
      Severity: Minor
      Found in lib/websocket/transports/engineio/client.js and 1 other location - About 35 mins to fix
      lib/websocket/transports/engineio/client.js on lines 1929..1931

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            for (var i = 0; i < contentArray.length; i++) {
              resultBuffer[i+1] = contentArray[i];
            }
      Severity: Minor
      Found in lib/websocket/transports/engineio/client.js and 1 other location - About 35 mins to fix
      lib/websocket/transports/engineio/client.js on lines 3600..3602

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid too many return statements within this function.
      Open

            return false;
      Severity: Major
      Found in lib/websocket/transports/engineio/client.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return '<p>'
                + this.parseText()
                + '</p>\n';
        Severity: Major
        Found in docs/js/marked.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return callback(err, 0, 1);
          Severity: Major
          Found in lib/websocket/transports/engineio/client.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return '<table>\n'
                    + body
                    + '</table>\n';
            Severity: Major
            Found in docs/js/marked.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return '<'
                      + type
                      + '>\n'
                      + body
                      + '</'
              Severity: Major
              Found in docs/js/marked.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return '<li>'
                        + body
                        + '</li>\n';
                Severity: Major
                Found in docs/js/marked.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return charsetPart.charCodeAt(1);
                  Severity: Major
                  Found in docs/js/google-code-prettify.js - About 30 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language