Sign upLogin

soderlind/read-offline

View on GitHub
Star

Showing 1,262 of 1,262 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    function pdf( $attributes, $content ) {
        global $post;
        if ( ! is_object( $post ) ) { return; }

        $attributes = shortcode_atts( array(// default values
Severity: Major
Found in inc/class-read-offline-shortcode.php and 3 other locations - About 2 hrs to fix
inc/class-read-offline-shortcode.php on lines 41..51
inc/class-read-offline-shortcode.php on lines 53..63
inc/class-read-offline-shortcode.php on lines 65..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    function mobi( $attributes, $content ) {
        global $post;
        if ( ! is_object( $post ) ) { return; }

        $attributes = shortcode_atts( array(// default values
Severity: Major
Found in inc/class-read-offline-shortcode.php and 3 other locations - About 2 hrs to fix
inc/class-read-offline-shortcode.php on lines 29..39
inc/class-read-offline-shortcode.php on lines 41..51
inc/class-read-offline-shortcode.php on lines 65..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _split_content has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    private function _split_content( $html, $header ) {

        $all_tags   = ( 'all' === $header );
        $content    = array();
        $title      = '';
Severity: Minor
Found in inc/class-read-offline-create.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method save_as_attachment_to_post_type has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function save_as_attachment_to_post_type( $post_id, $post ) {

        // Autosave, do nothing
        if ( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE ) {
                return $post_id; }
Severity: Major
Found in inc/class-read-offline.php - About 2 hrs to fix

    File class-read-offline.php has 266 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

if ( ! defined( 'FS_CHMOD_DIR' ) ) {
    define( 'FS_CHMOD_DIR', ( 0755 & ~ umask() ) );
}
    Severity: Minor
    Found in inc/class-read-offline.php - About 2 hrs to fix

      Method parse_request has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function parse_request( $wp_query ) {
        global $post;
        $create_new = true;
        if ( '1' == parent::$options['misc']['cache'] ) {
            $create_new = false;
      Severity: Major
      Found in inc/class-read-offline-parser.php - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if ( false === isset( self::$options['mobi']['add_toc'] ) ) {
                self::$options['mobi']['add_toc'] = 0;
                self::$options['mobi']['toc'] = 0;
                update_option( 'Read_Offline_Admin_Settings', self::$options );
            }
        Severity: Major
        Found in inc/class-read-offline.php and 1 other location - About 2 hrs to fix
        inc/class-read-offline.php on lines 266..270

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if ( false === isset( self::$options['epub']['add_toc'] ) ) {
                self::$options['epub']['add_toc'] = 0;
                self::$options['epub']['toc'] = 0;
                update_option( 'Read_Offline_Admin_Settings', self::$options );
            }
        Severity: Major
        Found in inc/class-read-offline.php and 1 other location - About 2 hrs to fix
        inc/class-read-offline.php on lines 261..265

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function mobi has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

            function mobi( $post ) {

        $html = $this->html;
        $mobi = new MOBI();
        /*
        Severity: Minor
        Found in inc/class-read-offline-create.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function save_as_attachment_to_post_type has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            public function save_as_attachment_to_post_type( $post_id, $post ) {

        // Autosave, do nothing
        if ( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE ) {
                return $post_id; }
        Severity: Minor
        Found in inc/class-read-offline.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method embed_post has 52 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function embed_post( $content ) {
        global $post;
        if ( ! is_object( $post ) ) { return; }

        $placements = array_intersect_assoc(
        Severity: Major
        Found in inc/class-read-offline-ux.php - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      array(
                'field_id'         => 'password_owner',
                'section_id'       => 'pdf_protection',
                'title'            => __( 'Owners Password', 'read-offline' ),
                'description'      => __( 'If empty, a random (unknown) password will be generated', 'read-offline' ),
          Severity: Major
          Found in inc/class-read-offline-admin-settings.php and 1 other location - About 2 hrs to fix
          inc/class-read-offline-admin-settings.php on lines 993..1001

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 72.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      array(
                'field_id'         => 'password_user',
                'section_id'       => 'pdf_protection',
                'title'            => __( 'User Password', 'read-offline' ),
                'description'      => __( 'If empty, no password is required to open the PDF document', 'read-offline' ),
          Severity: Major
          Found in inc/class-read-offline-admin-settings.php and 1 other location - About 2 hrs to fix
          inc/class-read-offline-admin-settings.php on lines 984..992

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 72.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method mobi has 50 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function mobi( $post ) {

        $html = $this->html;
        $mobi = new MOBI();
        /*
          Severity: Minor
          Found in inc/class-read-offline-create.php - About 2 hrs to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                                  __( 'ISO 216 A', 'read-offline' ) => array(
                          'A0' => 'A0 (841x1189 mm ; 33.11x46.81 in)',
                          'A1' => 'A1 (594x841 mm ; 23.39x33.11 in)',
                          'A2' => 'A2 (420x594 mm ; 16.54x23.39 in)',
                          'A3' => 'A3 (297x420 mm ; 11.69x16.54 in)',
            Severity: Major
            Found in inc/class-read-offline-admin-settings.php and 2 other locations - About 2 hrs to fix
            inc/class-read-offline-admin-settings.php on lines 360..372
            inc/class-read-offline-admin-settings.php on lines 373..385

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 71.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                                  __( 'ISO 216 B', 'read-offline' ) => array(
                          'B0' => 'B0 (1000x1414 mm ; 39.37x55.67 in)',
                          'B1' => 'B1 (707x1000 mm ; 27.83x39.37 in)',
                          'B2' => 'B2 (500x707 mm ; 19.69x27.83 in)',
                          'B3' => 'B3 (353x500 mm ; 13.90x19.69 in)',
            Severity: Major
            Found in inc/class-read-offline-admin-settings.php and 2 other locations - About 2 hrs to fix
            inc/class-read-offline-admin-settings.php on lines 347..359
            inc/class-read-offline-admin-settings.php on lines 373..385

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 71.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                                  __( 'ISO 216 C', 'read-offline' ) => array(
                          'C0' => 'C0 (917x1297 mm ; 36.10x51.06 in)',
                          'C1' => 'C1 (648x917 mm ; 25.51x36.10 in)',
                          'C2' => 'C2 (458x648 mm ; 18.03x25.51 in)',
                          'C3' => 'C3 (324x458 mm ; 12.76x18.03 in)',
            Severity: Major
            Found in inc/class-read-offline-admin-settings.php and 2 other locations - About 2 hrs to fix
            inc/class-read-offline-admin-settings.php on lines 347..359
            inc/class-read-offline-admin-settings.php on lines 360..372

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 71.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function read_offline_admin_notice_php_warning() {
    $msg[] = '<div class="notice notice-warning is-dismissible "><p>';
    $msg[] = '<strong>Read Offline</strong>: Your current PHP version is ' . PHP_VERSION . '. <strong>Read Offline</strong> runs best on PHP 5.6 or greater.';
    $msg[] = '<a href="https://wordpress.org/about/requirements/">Ask</a> your hosting provider for an upgrade';
    $msg[] = '</p></div>';
            Severity: Major
            Found in read-offline.php and 1 other location - About 1 hr to fix
            read-offline.php on lines 70..76

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 67.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function read_offline_admin_notice_php_version() {
    $msg[] = '<div class="notice notice-error"><p>';
    $msg[] = '<strong>Read Offline</strong>: Your current PHP version is <strong>' . PHP_VERSION . '</strong>, please upgarde PHP at least to version 5.3 (PHP 5.6 or greater is reccomended). ';
    $msg[] = '<a href="https://wordpress.org/about/requirements/">Ask</a> your hosting provider for an upgrade';
    $msg[] = '</p></div>';
            Severity: Major
            Found in read-offline.php and 1 other location - About 1 hr to fix
            read-offline.php on lines 78..84

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 67.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if ( ( '0' == parent::$options['pdf_header']['default_header'][0] &&
                     '0' == parent::$options['pdf_header']['default_header'][1] &&
                     '0' == parent::$options['pdf_header']['default_header'][2] ) ) {
            Severity: Major
            Found in inc/class-read-offline-create.php and 1 other location - About 1 hr to fix
            inc/class-read-offline-create.php on lines 543..545

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language