Sign upLogin

soliantconsulting/SimpleFM

View on GitHub
Star
doc/filemaker/simplefm_example.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function arrayToParagraphs has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

function arrayToParagraphs($value)
{
    $count = count($value);
    if ($count) {
        $collapsedValue = '';
Severity: Minor
Found in doc/filemaker/simplefm_example.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method arrayToParagraphs uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            // repeating field
            $collapsedValue .= implode(PHP_EOL, $value);
        }
Severity: Minor
Found in doc/filemaker/simplefm_example.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method stringifyValue uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

    } else {
        $value = nl2br($value);
    }
Severity: Minor
Found in doc/filemaker/simplefm_example.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method arrayToParagraphs uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

    } else {
        return " ";
    }
Severity: Minor
Found in doc/filemaker/simplefm_example.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

There are no issues that match your filters.

Category
Status