Sign upLogin

soliantconsulting/SimpleFM

View on GitHub
Star

Showing 330 of 330 total issues

Avoid using static access to class '\Prophecy\Argument' in method 'testGetAssetWithNonSuccessResponse'.
Open

        $httpClient->sendRequest(Argument::any())->willReturn(new EmptyResponse(204));
Severity: Minor
Found in test/Connection/ConnectionTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Prophecy\Argument' in method 'testExternalMetadataCachingWithoutHit'.
Open

        $cache->save(Argument::that(function (CacheItemInterface $cacheItem) {
            return (
                'simplefm.metadata.ce2c8aed9c2fa0cfbed56cbda4d8bf07' === $cacheItem->getKey()
                && $cacheItem->get() instanceof Entity
            );
Severity: Minor
Found in test/Repository/Builder/Metadata/MetadataBuilderTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused private fields such as '$foo'.
Open

            private $foo = 'bar';
Severity: Minor
Found in test/Repository/Builder/MetadataExtractionTest.php by phpmd

UnusedPrivateField

Since: 0.2

Detects when a private field is declared and/or assigned a value, but not used.

Example

class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

Avoid using static access to class '\Soliant\SimpleFM\Connection\Exception\InvalidResponseException' in method 'testAuthenticator401NotFound'.
Open

        )->willThrow(InvalidResponseException::fromUnsuccessfulResponse($response->reveal()));
Severity: Minor
Found in test/Authentication/AuthenticationTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Litipk\BigNumbers\Decimal' in method 'validXmlProvider'.
Open

                        'Status' => Decimal::fromInteger(4),
Severity: Minor
Found in test/Client/ResultSet/ResultSetClientTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Litipk\BigNumbers\Decimal' in method 'validXmlProvider'.
Open

                        'Days Elapsed' => Decimal::fromInteger(9),
Severity: Minor
Found in test/Client/ResultSet/ResultSetClientTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Litipk\BigNumbers\Decimal' in method 'validXmlProvider'.
Open

                                'TASK ID MATCH FIELD' => Decimal::fromInteger(11),
Severity: Minor
Found in test/Client/ResultSet/ResultSetClientTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Litipk\BigNumbers\Decimal' in method 'validXmlProvider'.
Open

                                'TASK ID MATCH FIELD' => Decimal::fromInteger(4),
Severity: Minor
Found in test/Client/ResultSet/ResultSetClientTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Litipk\BigNumbers\Decimal' in method 'validXmlProvider'.
Open

                        'Status' => Decimal::fromInteger(4),
Severity: Minor
Found in test/Client/ResultSet/ResultSetClientTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Soliant\SimpleFM\Client\ResultSet\Exception\ParseException' in method 'execute'.
Open

            throw ParseException::fromConcreteException(
                (string) $dataSource['database'],
                (string) $dataSource['table'],
                (string) $dataSource['layout'],
                $e
Severity: Minor
Found in src/Client/ResultSet/ResultSetClient.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Litipk\BigNumbers\Decimal' in method 'validXmlProvider'.
Open

                        'Project Completion' => Decimal::fromString('0.4285714285714286'),
Severity: Minor
Found in test/Client/ResultSet/ResultSetClientTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DateTimeImmutable' in method '__invoke'.
Open

            throw DateTimeException::fromDateTimeError($value, DateTimeImmutable::getLastErrors());
Severity: Minor
Found in src/Client/ResultSet/Transformer/DateTimeTransformer.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DateTimeImmutable' in method '__invoke'.
Open

        $dateTime = DateTimeImmutable::createFromFormat(
            '!H:i:s',
            $value,
            self::$utcTimeZone ?: (self::$utcTimeZone = new DateTimeZone('UTC'))
        );
Severity: Minor
Found in src/Client/ResultSet/Transformer/TimeTransformer.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Soliant\SimpleFM\Client\Exception\FileMakerException' in method 'execute'.
Open

            throw FileMakerException::fromErrorCode($errorCode);
Severity: Minor
Found in src/Client/ResultSet/ResultSetClient.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Assert\Assertion' in method 'getIdentity'.
Open

        Assertion::notNull($this->identity);
Severity: Minor
Found in src/Connection/Command.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Soliant\SimpleFM\Connection\Exception\InvalidResponseException' in method 'getAsset'.
Open

            throw InvalidResponseException::fromUnsuccessfulResponse($response);
Severity: Minor
Found in src/Connection/Connection.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Soliant\SimpleFM\Repository\Builder\Metadata\Exception\InvalidFileException' in method 'getMetadata'.
Open

            throw InvalidFileException::fromNonExistentFile($xmlPath, $entityClassName);
Severity: Minor
Found in src/Repository/Builder/Metadata/MetadataBuilder.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Soliant\SimpleFM\Repository\Builder\Exception\HydrationException' in method 'hydrateWithMetadata'.
Open

                throw HydrationException::fromInvalidField($metadata, $fieldMetadata, $e);
Severity: Minor
Found in src/Repository/Builder/MetadataHydration.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method buildMetadata() has an NPath complexity of 3888. The configured NPath complexity threshold is 200.
Open

    private function buildMetadata(string $xmlPath) : Entity
    {
        $xml = $this->loadValidatedXml($xmlPath);
        $fields = [];
        $embeddables = [];
Severity: Minor
Found in src/Repository/Builder/Metadata/MetadataBuilder.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

Avoid using static access to class '\Litipk\BigNumbers\Decimal' in method 'fromFileMakerValue'.
Open

            return 0 !== $value->comp(Decimal::fromInteger(0));
Severity: Minor
Found in src/Repository/Builder/Type/BooleanType.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language