Sign upLogin

soliantconsulting/SimpleFM

View on GitHub
Star

Showing 330 of 330 total issues

Avoid using static access to class '\Assert\Assertion' in method 'buildRequest'.
Open

            Assertion::notNull($this->identityHandler, 'An identity handler must be set to use identities on commands');
Severity: Minor
Found in src/Connection/Connection.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Assert\Assertion' in method 'validateArray'.
Open

        Assertion::count(array_filter($array, function ($metadata) use ($expectedClassName) : bool {
            return !$metadata instanceof $expectedClassName;
        }), 0, sprintf('At least one element in array is not an instance of %s', $expectedClassName));
Severity: Minor
Found in src/Repository/Builder/Metadata/Entity.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Assert\Assertion' in method '__construct'.
Open

            Assertion::notNull($targetPropertyName);
Severity: Minor
Found in src/Repository/Builder/Metadata/OneToOne.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Assert\Assertion' in method 'toFileMakerValue'.
Open

        Assertion::isInstanceOf($value, DateTimeInterface::class);
Severity: Minor
Found in src/Repository/Builder/Type/DateType.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Soliant\SimpleFM\Repository\Builder\Type\Exception\DomainException' in method 'toFileMakerValue'.
Open

        throw DomainException::fromAttemptedStreamConversionToFileMakerValue();
Severity: Minor
Found in src/Repository/Builder/Type/StreamType.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Assert\Assertion' in method 'toFileMakerValue'.
Open

        Assertion::isInstanceOf($value, DateTimeInterface::class);
Severity: Minor
Found in src/Repository/Builder/Type/TimeType.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Soliant\SimpleFM\Repository\Exception\DomainException' in method 'createSortParameters'.
Open

            throw DomainException::fromTooManySortParameters(9, $sort);
Severity: Minor
Found in src/Repository/Repository.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method testOneToOneInverseHydrationWithEntity uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $repository->findOneBy(['ID' => '5'])->willReturn('parent-entity');
            $repository->quoteString('5')->willReturn('5');
        }
Severity: Minor
Found in test/Repository/Builder/MetadataHydrationTest.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Litipk\BigNumbers\Decimal' in method 'testSuccessfulConversionFromFileMaker'.
Open

        $value = Decimal::fromInteger(1);
Severity: Minor
Found in test/Repository/Builder/Type/DecimalTypeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Soliant\SimpleFM\Client\ResultSet\Exception\ParseException' in method 'execute'.
Open

            throw ParseException::fromConcreteException(
                (string) $dataSource['database'],
                (string) $dataSource['table'],
                (string) $dataSource['layout'],
                $e
Severity: Minor
Found in src/Client/ResultSet/ResultSetClient.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Soliant\SimpleFM\Client\ResultSet\Exception\UnknownFieldException' in method 'getFieldTransformer'.
Open

            throw UnknownFieldException::fromUnknownField();
Severity: Minor
Found in src/Client/ResultSet/ResultSetClient.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DateTimeImmutable' in method '__invoke'.
Open

        $dateTime = DateTimeImmutable::createFromFormat(
            '!m/d/Y',
            $value,
            self::$utcTimeZone ?: (self::$utcTimeZone = new DateTimeZone('UTC'))
        );
Severity: Minor
Found in src/Client/ResultSet/Transformer/DateTransformer.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Litipk\BigNumbers\Decimal' in method '__invoke'.
Open

        return Decimal::fromString(rtrim($cleanedValue, '.'));
Severity: Minor
Found in src/Client/ResultSet/Transformer/NumberTransformer.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method buildMetadata() has an NPath complexity of 3888. The configured NPath complexity threshold is 200.
Open

    private function buildMetadata(string $xmlPath) : Entity
    {
        $xml = $this->loadValidatedXml($xmlPath);
        $fields = [];
        $embeddables = [];
Severity: Minor
Found in src/Repository/Builder/Metadata/MetadataBuilder.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

Avoid using static access to class '\Soliant\SimpleFM\Repository\Builder\Metadata\Exception\InvalidTypeException' in method 'buildMetadata'.
Open

                    throw InvalidTypeException::fromNonExistentType($type);
Severity: Minor
Found in src/Repository/Builder/Metadata/MetadataBuilder.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Soliant\SimpleFM\Repository\Builder\Exception\ExtractionException' in method 'extractWithMetadata'.
Open

                throw ExtractionException::fromInvalidField($metadata, $fieldMetadata, $e);
Severity: Minor
Found in src/Repository/Builder/MetadataExtraction.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Assert\Assertion' in method 'hydrateWithMetadata'.
Open

            Assertion::true(
                $metadata->hasInterfaceName(),
                sprintf('Entity "%s" has no interface name definied', $metadata->getClassName())
            );
Severity: Minor
Found in src/Repository/Builder/MetadataHydration.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Litipk\BigNumbers\Decimal' in method 'fromFileMakerValue'.
Open

            return 0 !== $value->comp(Decimal::fromInteger(0));
Severity: Minor
Found in src/Repository/Builder/Type/BooleanType.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method testManyToOneHydrationWithChild uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $this->assertInstanceOf(ProxyInterface::class, $entity->baz);
            $this->assertSame('child-entity', $entity->baz->__getRealEntity());
        }
Severity: Minor
Found in test/Repository/Builder/MetadataHydrationTest.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\DateTimeImmutable' in method '__invoke'.
Open

        $dateTime = DateTimeImmutable::createFromFormat(
            '!H:i:s',
            $value,
            self::$utcTimeZone ?: (self::$utcTimeZone = new DateTimeZone('UTC'))
        );
Severity: Minor
Found in src/Client/ResultSet/Transformer/TimeTransformer.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language