Sign upLogin

soliantconsulting/SimpleFM

View on GitHub
Star

Showing 330 of 330 total issues

The class MetadataBuilderTest has 27 non-getter- and setter-methods. Consider refactoring MetadataBuilderTest to keep number of methods under 25.
Open

final class MetadataBuilderTest extends TestCase
{
    public function testInvalidType()
    {
        $this->expectException(InvalidArgumentException::class);
Severity: Minor
Found in test/Repository/Builder/Metadata/MetadataBuilderTest.php by phpmd

TooManyMethods

Since: 0.1

A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

The default was changed from 10 to 25 in PHPMD 2.3.

Example

Source https://phpmd.org/rules/codesize.html#toomanymethods

The class Repository has 12 public methods. Consider refactoring Repository to keep number of public methods under 10.
Open

final class Repository implements RepositoryInterface
{
    /**
     * @var ResultSetClientInterface
     */
Severity: Minor
Found in src/Repository/Repository.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The class MetadataHydrationTest has 15 public methods. Consider refactoring MetadataHydrationTest to keep number of public methods under 10.
Open

final class MetadataHydrationTest extends TestCase
{
    public function testSimpleFieldHydration()
    {
        $entityPrototype = new class
Severity: Minor
Found in test/Repository/Builder/MetadataHydrationTest.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The class MetadataBuilderTest has 27 public methods. Consider refactoring MetadataBuilderTest to keep number of public methods under 10.
Open

final class MetadataBuilderTest extends TestCase
{
    public function testInvalidType()
    {
        $this->expectException(InvalidArgumentException::class);
Severity: Minor
Found in test/Repository/Builder/Metadata/MetadataBuilderTest.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The class ResultSetClientTest has 12 public methods. Consider refactoring ResultSetClientTest to keep number of public methods under 10.
Open

final class ResultSetClientTest extends TestCase
{
    public static function validXmlProvider() : array
    {
        return [
Severity: Minor
Found in test/Client/ResultSet/ResultSetClientTest.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The class RepositoryTest has 31 non-getter- and setter-methods. Consider refactoring RepositoryTest to keep number of methods under 25.
Open

final class RepositoryTest extends TestCase
{
    public function testQuoteStringUsesClientMethod()
    {
        $resultSetClient = $this->prophesize(ResultSetClientInterface::class);
Severity: Minor
Found in test/Repository/RepositoryTest.php by phpmd

TooManyMethods

Since: 0.1

A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

The default was changed from 10 to 25 in PHPMD 2.3.

Example

Source https://phpmd.org/rules/codesize.html#toomanymethods

The class RepositoryTest has 29 public methods. Consider refactoring RepositoryTest to keep number of public methods under 10.
Open

final class RepositoryTest extends TestCase
{
    public function testQuoteStringUsesClientMethod()
    {
        $resultSetClient = $this->prophesize(ResultSetClientInterface::class);
Severity: Minor
Found in test/Repository/RepositoryTest.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The class ConnectionTest has 11 public methods. Consider refactoring ConnectionTest to keep number of public methods under 10.
Open

final class ConnectionTest extends TestCase
{
    public function testNonSuccessResponse()
    {
        $httpClient = $this->prophesize(HttpClient::class);
Severity: Minor
Found in test/Connection/ConnectionTest.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Method buildProxyClass has 83 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function buildProxyClass(
        string $entityInterfaceName,
        string $proxyNamespace,
        string $proxyClassName
    ) : string {
Severity: Major
Found in src/Repository/Builder/Proxy/ProxyBuilder.php - About 3 hrs to fix

    MetadataBuilderTest has 27 functions (exceeds 20 allowed). Consider refactoring.
    Open

    final class MetadataBuilderTest extends TestCase
{
    public function testInvalidType()
    {
        $this->expectException(InvalidArgumentException::class);
    Severity: Minor
    Found in test/Repository/Builder/Metadata/MetadataBuilderTest.php - About 3 hrs to fix

      Function extractWithMetadata has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

          private function extractWithMetadata($entity, Entity $metadata) : array
    {
        if ($entity instanceof ProxyInterface) {
            $entity = $entity->__getRealEntity();
        }
      Severity: Minor
      Found in src/Repository/Builder/MetadataExtraction.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method extractWithMetadata has 76 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function extractWithMetadata($entity, Entity $metadata) : array
    {
        if ($entity instanceof ProxyInterface) {
            $entity = $entity->__getRealEntity();
        }
      Severity: Major
      Found in src/Repository/Builder/MetadataExtraction.php - About 3 hrs to fix

        Function arrayToParagraphs has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

        function arrayToParagraphs($value)
{
    $count = count($value);
    if ($count) {
        $collapsedValue = '';
        Severity: Minor
        Found in doc/filemaker/simplefm_example.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File MetadataBuilderTest.php has 270 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
declare(strict_types = 1);

namespace SoliantTest\SimpleFM\Repository\Builder\Metadata;
        Severity: Minor
        Found in test/Repository/Builder/Metadata/MetadataBuilderTest.php - About 2 hrs to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  $entityMetadata = new Entity('foo', get_class($entityPrototype), [], [
            new Embeddable('baz', 'bazPrefix', new Entity('', get_class($embeddablePrototype), [
                new Field('fooField', 'foo', new StringType(), false, false),
            ], [], [], [], [])),
        ], [], [], []);
          Severity: Major
          Found in test/Repository/Builder/MetadataHydrationTest.php and 2 other locations - About 2 hrs to fix
          test/Repository/Builder/MetadataExtractionTest.php on lines 134..138
          test/Repository/Builder/MetadataHydrationTest.php on lines 138..142

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 129.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  $entityMetadata = new Entity('foo', get_class($entityPrototype), [], [
            new Embeddable('baz', '', new Entity('', get_class($embeddablePrototype), [
                new Field('fooField', 'foo', new StringType(), false, false),
            ], [], [], [], [])),
        ], [], [], []);
          Severity: Major
          Found in test/Repository/Builder/MetadataHydrationTest.php and 2 other locations - About 2 hrs to fix
          test/Repository/Builder/MetadataExtractionTest.php on lines 134..138
          test/Repository/Builder/MetadataHydrationTest.php on lines 165..169

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 129.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  $entityMetadata = new Entity('foo', get_class($entity), [], [
            new Embeddable('baz', 'bazPrefix', new Entity('', get_class($embeddable), [
                new Field('fooField', 'foo', new StringType(), false, false),
            ], [], [], [], [])),
        ], [], [], []);
          Severity: Major
          Found in test/Repository/Builder/MetadataExtractionTest.php and 2 other locations - About 2 hrs to fix
          test/Repository/Builder/MetadataHydrationTest.php on lines 138..142
          test/Repository/Builder/MetadataHydrationTest.php on lines 165..169

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 129.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method testOneToOneInverseHydrationWithEntity has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function testOneToOneInverseHydrationWithEntity(bool $eagerHydration)
    {
        $entityPrototype = new class
        {
            public $baz;
          Severity: Minor
          Found in test/Repository/Builder/MetadataHydrationTest.php - About 1 hr to fix

            Method testOneToOneOwningHydrationWithEntity has 47 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function testOneToOneOwningHydrationWithEntity(bool $eagerHydration)
    {
        $entityPrototype = new class
        {
            public $baz;
            Severity: Minor
            Found in test/Repository/Builder/MetadataHydrationTest.php - About 1 hr to fix

              Method testManyToOneHydrationWithChild has 46 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function testManyToOneHydrationWithChild(bool $eagerHydration)
    {
        $entityPrototype = new class
        {
            public $baz;
              Severity: Minor
              Found in test/Repository/Builder/MetadataHydrationTest.php - About 1 hr to fix
                Severity
                Category
                Status
                Source
                Language