Sign upLogin

soliantconsulting/SimpleFM

View on GitHub
Star

Showing 330 of 330 total issues

The method testOneToManyHydrationWithEntity uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $testCase = $this;
            $repository->findByQuery(Argument::any())->will(function (array $parameters) use ($testCase) {
                $testCase->assertSame('5', $parameters[0]->toParameters()['-q1.value']);
                $testCase->assertSame('6', $parameters[0]->toParameters()['-q2.value']);
Severity: Minor
Found in test/Repository/Builder/MetadataHydrationTest.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\DateTimeImmutable' in method 'testSuccessfulConversionToFileMaker'.
Open

            (new DateType())->toFileMakerValue(DateTimeImmutable::createFromFormat('!m/d/Y', '01/23/4567'))
Severity: Minor
Found in test/Repository/Builder/Type/DateTypeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Litipk\BigNumbers\Decimal' in method 'validXmlProvider'.
Open

                        'PROJECT ID MATCH FIELD' => Decimal::fromInteger(7),
Severity: Minor
Found in test/Client/ResultSet/ResultSetClientTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Soliant\SimpleFM\Client\Exception\FileMakerException' in method 'testInvalidFileMakerExceptionCode'.
Open

        throw FileMakerException::fromErrorCode(-100);
Severity: Minor
Found in test/Client/ResultSet/ResultSetClientTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Litipk\BigNumbers\Decimal' in method 'testNumberCleanup'.
Open

        $this->assertEquals($numberTransformer($fileMakerValue), Decimal::fromString($expectedValue));
Severity: Minor
Found in test/Client/ResultSet/Type/NumberTransformerTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Assert\Assertion' in method 'getIdentity'.
Open

        Assertion::notNull($this->identity);
Severity: Minor
Found in src/Authentication/Result.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Soliant\SimpleFM\Connection\Exception\InvalidResponseException' in method 'execute'.
Open

            throw InvalidResponseException::fromUnsuccessfulResponse($response);
Severity: Minor
Found in src/Connection/Connection.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Soliant\SimpleFM\Connection\Exception\InvalidResponseException' in method 'execute'.
Open

            throw InvalidResponseException::fromXmlError(libxml_get_last_error());
Severity: Minor
Found in src/Connection/Connection.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Assert\Assertion' in method 'buildRequest'.
Open

            Assertion::notNull($this->identityHandler, 'An identity handler must be set to use identities on commands');
Severity: Minor
Found in src/Connection/Connection.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Assert\Assertion' in method 'getTargetPropertyName'.
Open

        Assertion::notNull($this->targetPropertyName);
Severity: Minor
Found in src/Repository/Builder/Metadata/OneToOne.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method hydrateWithMetadata uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $prefixLength = strlen($prefix);

                foreach ($data as $key => $value) {
                    if (0 !== strpos($key, $prefix)) {
Severity: Minor
Found in src/Repository/Builder/MetadataHydration.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method arrayToParagraphs uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            // repeating field
            $collapsedValue .= implode(PHP_EOL, $value);
        }
Severity: Minor
Found in doc/filemaker/simplefm_example.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Assert\Assertion' in method 'fromFileMakerValue'.
Open

        Assertion::isInstanceOf($value, DateTimeInterface::class);
Severity: Minor
Found in src/Repository/Builder/Type/TimeType.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Litipk\BigNumbers\Decimal' in method 'validXmlProvider'.
Open

                                    Decimal::fromInteger(3),
Severity: Minor
Found in test/Client/ResultSet/ResultSetClientTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Litipk\BigNumbers\Decimal' in method 'validXmlProvider'.
Open

                                    Decimal::fromInteger(8),
Severity: Minor
Found in test/Client/ResultSet/ResultSetClientTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DateTimeImmutable' in method '__invoke'.
Open

        $dateTime = DateTimeImmutable::createFromFormat(
            '!m/d/Y',
            $value,
            self::$utcTimeZone ?: (self::$utcTimeZone = new DateTimeZone('UTC'))
        );
Severity: Minor
Found in src/Client/ResultSet/Transformer/DateTransformer.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Prophecy\Argument' in method 'createAssertiveRepository'.
Open

            $resultSetClient->execute(Argument::any())->will(function (array $parameters) use ($resultSetCallback) {
Severity: Minor
Found in test/Repository/RepositoryTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Prophecy\Argument' in method 'createResultSetClientProphecy'.
Open

        $resultSetClient->quoteString(\Prophecy\Argument::any())->will(function (array $parameters) : string {
Severity: Minor
Found in test/Authentication/AuthenticationTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Litipk\BigNumbers\Decimal' in method 'testSuccessfulConversionToFileMaker'.
Open

        $value = Decimal::fromInteger(1);
Severity: Minor
Found in test/Repository/Builder/Type/DecimalTypeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DateTimeImmutable' in method 'testSuccessfulConversionToFileMaker'.
Open

            (new TimeType())->toFileMakerValue(DateTimeImmutable::createFromFormat('!H:i:s', '01:23:45'))
Severity: Minor
Found in test/Repository/Builder/Type/TimeTypeTest.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language