Sign upLogin

soliantconsulting/SimpleFM

View on GitHub
Star
src/Connection/Connection.php

Summary

Maintainability
A
35 mins
Test Coverage
A
100%

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        HttpClient $httpClient,
        UriInterface $uri,
        string $database,
        IdentityHandlerInterface $identityHandler = null,
        LoggerInterface $logger = null
Severity: Minor
Found in src/Connection/Connection.php - About 35 mins to fix

    The class Connection has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
    Open

    final class Connection implements ConnectionInterface
{
    /**
     * @var HttpClient
     */
    Severity: Minor
    Found in src/Connection/Connection.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    Avoid using static access to class '\Soliant\SimpleFM\Connection\Exception\InvalidResponseException' in method 'execute'.
    Open

                throw InvalidResponseException::fromUnsuccessfulResponse($response);
    Severity: Minor
    Found in src/Connection/Connection.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Soliant\SimpleFM\Connection\Exception\InvalidResponseException' in method 'execute'.
    Open

                throw InvalidResponseException::fromXmlError(libxml_get_last_error());
    Severity: Minor
    Found in src/Connection/Connection.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Assert\Assertion' in method 'buildRequest'.
    Open

                Assertion::notNull($this->identityHandler, 'An identity handler must be set to use identities on commands');
    Severity: Minor
    Found in src/Connection/Connection.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class '\Soliant\SimpleFM\Connection\Exception\InvalidResponseException' in method 'getAsset'.
    Open

                throw InvalidResponseException::fromUnsuccessfulResponse($response);
    Severity: Minor
    Found in src/Connection/Connection.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    There are no issues that match your filters.

    Category
    Status