soliantconsulting/SimpleFM

View on GitHub
src/Repository/Builder/Metadata/OneToMany.php

Summary

Maintainability
A
35 mins
Test Coverage
A
100%

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        string $propertyName,
        string $targetTable,
        string $targetEntity,
        string $targetFieldName,
        bool $eagerHydration = false
Severity: Minor
Found in src/Repository/Builder/Metadata/OneToMany.php - About 35 mins to fix

    The method __construct has a boolean flag argument $eagerHydration, which is a certain sign of a Single Responsibility Principle violation.
    Open

            bool $eagerHydration = false

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
        public function bar($flag = true) {
        }
    }

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    There are no issues that match your filters.

    Category
    Status