soliantconsulting/SimpleFM

View on GitHub
src/Repository/RepositoryInterface.php

Summary

Maintainability
A
35 mins
Test Coverage
F
0%

Method findBy has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        array $search,
        array $sort = [],
        int $limit = null,
        int $offset = null,
        bool $autoQuoteSearch = true
Severity: Minor
Found in src/Repository/RepositoryInterface.php - About 35 mins to fix

    The method findOneBy has a boolean flag argument $autoQuoteSearch, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function findOneBy(array $search, bool $autoQuoteSearch = true);

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
        public function bar($flag = true) {
        }
    }

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method delete has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function delete($entity, bool $force = false);

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
        public function bar($flag = true) {
        }
    }

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method findBy has a boolean flag argument $autoQuoteSearch, which is a certain sign of a Single Responsibility Principle violation.
    Open

            bool $autoQuoteSearch = true

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
        public function bar($flag = true) {
        }
    }

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method update has a boolean flag argument $force, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function update($entity, bool $force = false);

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
        public function bar($flag = true) {
        }
    }

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    There are no issues that match your filters.

    Category
    Status