soliantconsulting/SimpleFM

View on GitHub
test/Repository/Builder/Metadata/MetadataBuilderTest.php

Summary

Maintainability
C
1 day
Test Coverage

The class MetadataBuilderTest has 27 non-getter- and setter-methods. Consider refactoring MetadataBuilderTest to keep number of methods under 25.
Open

final class MetadataBuilderTest extends TestCase
{
    public function testInvalidType()
    {
        $this->expectException(InvalidArgumentException::class);

TooManyMethods

Since: 0.1

A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

The default was changed from 10 to 25 in PHPMD 2.3.

Example

Source https://phpmd.org/rules/codesize.html#toomanymethods

The class MetadataBuilderTest has 27 public methods. Consider refactoring MetadataBuilderTest to keep number of public methods under 10.
Open

final class MetadataBuilderTest extends TestCase
{
    public function testInvalidType()
    {
        $this->expectException(InvalidArgumentException::class);

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

MetadataBuilderTest has 27 functions (exceeds 20 allowed). Consider refactoring.
Open

final class MetadataBuilderTest extends TestCase
{
    public function testInvalidType()
    {
        $this->expectException(InvalidArgumentException::class);
Severity: Minor
Found in test/Repository/Builder/Metadata/MetadataBuilderTest.php - About 3 hrs to fix

    File MetadataBuilderTest.php has 270 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    declare(strict_types = 1);
    
    namespace SoliantTest\SimpleFM\Repository\Builder\Metadata;
    
    
    Severity: Minor
    Found in test/Repository/Builder/Metadata/MetadataBuilderTest.php - About 2 hrs to fix

      The class MetadataBuilderTest has a coupling between objects value of 20. Consider to reduce the number of dependencies under 13.
      Open

      final class MetadataBuilderTest extends TestCase
      {
          public function testInvalidType()
          {
              $this->expectException(InvalidArgumentException::class);

      CouplingBetweenObjects

      Since: 1.1.0

      A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

      Example

      class Foo {
          /**
           * @var \foo\bar\X
           */
          private $x = null;
      
          /**
           * @var \foo\bar\Y
           */
          private $y = null;
      
          /**
           * @var \foo\bar\Z
           */
          private $z = null;
      
          public function setFoo(\Foo $foo) {}
          public function setBar(\Bar $bar) {}
          public function setBaz(\Baz $baz) {}
      
          /**
           * @return \SplObjectStorage
           * @throws \OutOfRangeException
           * @throws \InvalidArgumentException
           * @throws \ErrorException
           */
          public function process(\Iterator $it) {}
      
          // ...
      }

      Source https://phpmd.org/rules/design.html#couplingbetweenobjects

      Avoid using static access to class '\Prophecy\Argument' in method 'testExternalMetadataCachingWithoutHit'.
      Open

              $cache->save(Argument::that(function (CacheItemInterface $cacheItem) {
                  return (
                      'simplefm.metadata.ce2c8aed9c2fa0cfbed56cbda4d8bf07' === $cacheItem->getKey()
                      && $cacheItem->get() instanceof Entity
                  );

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Prophecy\Argument' in method 'testExternalMetadataCachingWithHit'.
      Open

              $cache->save(Argument::any())->shouldNotBeCalled();

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

          public function testReadOnlyFields()
          {
              $builder = new MetadataBuilder(__DIR__ . '/TestAssets');
              $metadata = $builder->getMetadata('ReadOnly');
      
      
      Severity: Major
      Found in test/Repository/Builder/Metadata/MetadataBuilderTest.php and 7 other locations - About 35 mins to fix
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 162..170
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 182..190
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 192..200
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 202..210
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 212..220
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 222..230
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 232..240

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

          public function testRepeatable()
          {
              $builder = new MetadataBuilder(__DIR__ . '/TestAssets');
              $metadata = $builder->getMetadata('Repeatable');
      
      
      Severity: Major
      Found in test/Repository/Builder/Metadata/MetadataBuilderTest.php and 7 other locations - About 35 mins to fix
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 172..180
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 182..190
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 192..200
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 202..210
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 212..220
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 222..230
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 232..240

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

          public function testReadOnlyManyToOne()
          {
              $builder = new MetadataBuilder(__DIR__ . '/TestAssets');
              $metadata = $builder->getMetadata('ReadOnly');
      
      
      Severity: Major
      Found in test/Repository/Builder/Metadata/MetadataBuilderTest.php and 7 other locations - About 35 mins to fix
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 162..170
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 172..180
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 192..200
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 202..210
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 212..220
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 222..230
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 232..240

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

          public function testReadOnlyOneToOne()
          {
              $builder = new MetadataBuilder(__DIR__ . '/TestAssets');
              $metadata = $builder->getMetadata('ReadOnly');
      
      
      Severity: Major
      Found in test/Repository/Builder/Metadata/MetadataBuilderTest.php and 7 other locations - About 35 mins to fix
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 162..170
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 172..180
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 182..190
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 202..210
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 212..220
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 222..230
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 232..240

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

          public function testEagerHydrationOneToMany()
          {
              $builder = new MetadataBuilder(__DIR__ . '/TestAssets');
              $metadata = $builder->getMetadata('EagerHydration');
      
      
      Severity: Major
      Found in test/Repository/Builder/Metadata/MetadataBuilderTest.php and 7 other locations - About 35 mins to fix
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 162..170
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 172..180
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 182..190
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 192..200
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 212..220
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 222..230
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 232..240

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

          public function testEagerHydrationManyToOne()
          {
              $builder = new MetadataBuilder(__DIR__ . '/TestAssets');
              $metadata = $builder->getMetadata('EagerHydration');
      
      
      Severity: Major
      Found in test/Repository/Builder/Metadata/MetadataBuilderTest.php and 7 other locations - About 35 mins to fix
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 162..170
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 172..180
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 182..190
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 192..200
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 202..210
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 222..230
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 232..240

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

          public function testEagerHydrationOneToOneInverse()
          {
              $builder = new MetadataBuilder(__DIR__ . '/TestAssets');
              $metadata = $builder->getMetadata('EagerHydration');
      
      
      Severity: Major
      Found in test/Repository/Builder/Metadata/MetadataBuilderTest.php and 7 other locations - About 35 mins to fix
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 162..170
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 172..180
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 182..190
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 192..200
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 202..210
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 212..220
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 222..230

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

          public function testEagerHydrationOneToOneOwning()
          {
              $builder = new MetadataBuilder(__DIR__ . '/TestAssets');
              $metadata = $builder->getMetadata('EagerHydration');
      
      
      Severity: Major
      Found in test/Repository/Builder/Metadata/MetadataBuilderTest.php and 7 other locations - About 35 mins to fix
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 162..170
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 172..180
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 182..190
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 192..200
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 202..210
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 212..220
      test/Repository/Builder/Metadata/MetadataBuilderTest.php on lines 232..240

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status