soliantconsulting/SimpleFM

View on GitHub
test/Repository/RepositoryTest.php

Summary

Maintainability
D
2 days
Test Coverage

File RepositoryTest.php has 454 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
declare(strict_types = 1);

namespace SoliantTest\SimpleFM\Repository;

Severity: Minor
Found in test/Repository/RepositoryTest.php - About 6 hrs to fix

    RepositoryTest has 31 functions (exceeds 20 allowed). Consider refactoring.
    Open

    final class RepositoryTest extends TestCase
    {
        public function testQuoteStringUsesClientMethod()
        {
            $resultSetClient = $this->prophesize(ResultSetClientInterface::class);
    Severity: Minor
    Found in test/Repository/RepositoryTest.php - About 3 hrs to fix

      The class RepositoryTest has 31 non-getter- and setter-methods. Consider refactoring RepositoryTest to keep number of methods under 25.
      Open

      final class RepositoryTest extends TestCase
      {
          public function testQuoteStringUsesClientMethod()
          {
              $resultSetClient = $this->prophesize(ResultSetClientInterface::class);
      Severity: Minor
      Found in test/Repository/RepositoryTest.php by phpmd

      TooManyMethods

      Since: 0.1

      A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

      By default it ignores methods starting with 'get' or 'set'.

      The default was changed from 10 to 25 in PHPMD 2.3.

      Example

      Source https://phpmd.org/rules/codesize.html#toomanymethods

      The class RepositoryTest has 29 public methods. Consider refactoring RepositoryTest to keep number of public methods under 10.
      Open

      final class RepositoryTest extends TestCase
      {
          public function testQuoteStringUsesClientMethod()
          {
              $resultSetClient = $this->prophesize(ResultSetClientInterface::class);
      Severity: Minor
      Found in test/Repository/RepositoryTest.php by phpmd

      TooManyPublicMethods

      Since: 0.1

      A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

      By default it ignores methods starting with 'get' or 'set'.

      Example

      Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

      The class RepositoryTest has a coupling between objects value of 15. Consider to reduce the number of dependencies under 13.
      Open

      final class RepositoryTest extends TestCase
      {
          public function testQuoteStringUsesClientMethod()
          {
              $resultSetClient = $this->prophesize(ResultSetClientInterface::class);
      Severity: Minor
      Found in test/Repository/RepositoryTest.php by phpmd

      CouplingBetweenObjects

      Since: 1.1.0

      A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

      Example

      class Foo {
          /**
           * @var \foo\bar\X
           */
          private $x = null;
      
          /**
           * @var \foo\bar\Y
           */
          private $y = null;
      
          /**
           * @var \foo\bar\Z
           */
          private $z = null;
      
          public function setFoo(\Foo $foo) {}
          public function setBar(\Bar $bar) {}
          public function setBaz(\Baz $baz) {}
      
          /**
           * @return \SplObjectStorage
           * @throws \OutOfRangeException
           * @throws \InvalidArgumentException
           * @throws \ErrorException
           */
          public function process(\Iterator $it) {}
      
          // ...
      }

      Source https://phpmd.org/rules/design.html#couplingbetweenobjects

      Avoid using static access to class '\Prophecy\Argument' in method 'createAssertiveRepository'.
      Open

                  $resultSetClient->execute(Argument::any())->will(function (array $parameters) use ($resultSetCallback) {
      Severity: Minor
      Found in test/Repository/RepositoryTest.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid using static access to class '\Prophecy\Argument' in method 'createAssertiveRepository'.
      Open

              $resultSetClient->quoteString(Argument::any())->will(function (array $parameters) {
      Severity: Minor
      Found in test/Repository/RepositoryTest.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid unused parameters such as '$command'.
      Open

              $repository = $this->createAssertiveRepository(function (Command $command) {
      Severity: Minor
      Found in test/Repository/RepositoryTest.php by phpmd

      UnusedFormalParameter

      Since: 0.2

      Avoid passing parameters to methods or constructors and then not using those parameters.

      Example

      class Foo
      {
          private function bar($howdy)
          {
              // $howdy is not used
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              $repository = $this->createAssertiveRepository(function (Command $command) use (&$index) {
                  $this->assertSame([
                      '-lay=foo&-recid=1&-find&-max=1',
                      '-lay=foo&foo=bar&-recid=1&-edit',
                  ][++$index], (string) $command);
      Severity: Major
      Found in test/Repository/RepositoryTest.php and 5 other locations - About 55 mins to fix
      test/Repository/RepositoryTest.php on lines 310..316
      test/Repository/RepositoryTest.php on lines 369..375
      test/Repository/RepositoryTest.php on lines 390..396
      test/Repository/RepositoryTest.php on lines 411..417
      test/Repository/RepositoryTest.php on lines 441..447

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 99.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              $repository = $this->createAssertiveRepository(function (Command $command) use (&$index) {
                  $this->assertSame([
                      '-lay=foo&-recid=1&-find&-max=1',
                      '-lay=foo&-recid=1&-delete&-modid=1',
                  ][++$index], (string) $command);
      Severity: Major
      Found in test/Repository/RepositoryTest.php and 5 other locations - About 55 mins to fix
      test/Repository/RepositoryTest.php on lines 310..316
      test/Repository/RepositoryTest.php on lines 335..341
      test/Repository/RepositoryTest.php on lines 369..375
      test/Repository/RepositoryTest.php on lines 411..417
      test/Repository/RepositoryTest.php on lines 441..447

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 99.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              $repository = $this->createAssertiveRepository(function (Command $command) use (&$index) {
                  $this->assertSame([
                      '-lay=foo&-recid=1&-find&-max=1',
                      '-lay=foo&foo=bar&-recid=1&-modid=1&-edit',
                  ][++$index], (string) $command);
      Severity: Major
      Found in test/Repository/RepositoryTest.php and 5 other locations - About 55 mins to fix
      test/Repository/RepositoryTest.php on lines 310..316
      test/Repository/RepositoryTest.php on lines 335..341
      test/Repository/RepositoryTest.php on lines 390..396
      test/Repository/RepositoryTest.php on lines 411..417
      test/Repository/RepositoryTest.php on lines 441..447

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 99.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              $repository = $this->createAssertiveRepository(function (Command $command) use (&$index) {
                  $this->assertSame([
                      '-lay=foo&-recid=1&-find&-max=1',
                      '-lay=foo&-recid=1&-delete',
                  ][++$index], (string) $command);
      Severity: Major
      Found in test/Repository/RepositoryTest.php and 5 other locations - About 55 mins to fix
      test/Repository/RepositoryTest.php on lines 310..316
      test/Repository/RepositoryTest.php on lines 335..341
      test/Repository/RepositoryTest.php on lines 369..375
      test/Repository/RepositoryTest.php on lines 390..396
      test/Repository/RepositoryTest.php on lines 441..447

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 99.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              $repository = $this->createAssertiveRepository(function (Command $command) use (&$index) {
                  $this->assertSame([
                      '-lay=foo&-recid=1&-find&-max=1',
                      '-lay=foo&foo=bar&-recid=1&-modid=1&-edit',
                  ][++$index], (string) $command);
      Severity: Major
      Found in test/Repository/RepositoryTest.php and 5 other locations - About 55 mins to fix
      test/Repository/RepositoryTest.php on lines 335..341
      test/Repository/RepositoryTest.php on lines 369..375
      test/Repository/RepositoryTest.php on lines 390..396
      test/Repository/RepositoryTest.php on lines 411..417
      test/Repository/RepositoryTest.php on lines 441..447

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 99.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              $repository = $this->createAssertiveRepository(function (Command $command) use (&$index) {
                  $this->assertSame([
                      '-lay=foo&-recid=1&-find&-max=1',
                      '-lay=foo&-recid=1&-delete&-modid=1',
                  ][++$index], (string) $command);
      Severity: Major
      Found in test/Repository/RepositoryTest.php and 5 other locations - About 55 mins to fix
      test/Repository/RepositoryTest.php on lines 310..316
      test/Repository/RepositoryTest.php on lines 335..341
      test/Repository/RepositoryTest.php on lines 369..375
      test/Repository/RepositoryTest.php on lines 390..396
      test/Repository/RepositoryTest.php on lines 411..417

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 99.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status