Sign upLogin

solsort/AppEdit

View on GitHub
Star

Showing 9 of 9 total issues

File appedit.js has 632 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// <img src=https://AppEdit.solsort.com/icon.png width=96 height=96 align=right>
//
// [![website](https://img.shields.io/badge/website-AppEdit.solsort.com-blue.svg)](https://AppEdit.solsort.com/)
// [![github](https://img.shields.io/badge/github-solsort/AppEdit-blue.svg)](https://github.com/solsort/AppEdit)
// [![codeclimate](https://img.shields.io/codeclimate/github/solsort/AppEdit.svg)](https://codeclimate.com/github/solsort/AppEdit)
Severity: Major
Found in appedit.js - About 1 day to fix

    Function createCodeMirror has 75 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function createCodeMirror() {
  var container = ss.bodyElem('codemirror-container');
  container.innerHTML = '<h1>Loading editor...</h1>';

  ss.loadCss('//unpkg.com/codemirror/lib/codemirror.css');
    Severity: Major
    Found in appedit.js - About 3 hrs to fix

      Function appProcess has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function appProcess() {
  var code = ss.getJS('code');

  if(runningApp) {
    rerunApp = true;
      Severity: Minor
      Found in appedit.js - About 1 hr to fix

        Function shareUrl has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function shareUrl(name, url, title) {
  url = encodeURIComponent(url);
  title = encodeURIComponent(title);
  return {
    twitter: `http://twitter.com/home?status=${title}+${url}`,
        Severity: Minor
        Found in appedit.js - About 1 hr to fix

          Function loadSourceCode has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function loadSourceCode() {
  var repos = ss.getJS(['route', 'github']);
  var sourceHash = ss.getJS(['route', 'sourceHash']);
  ss.set('route.sourceHash');
  ss.set('route.github');
          Severity: Minor
          Found in appedit.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            typeof document !== 'undefined' && ss.ready(() => {
  aboutElem = document.getElementById('about');
  aboutElem.remove();
});
            Severity: Minor
            Found in appedit.js and 1 other location - About 45 mins to fix
            appedit.js on lines 481..484

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            typeof document !== 'undefined' && ss.ready(() => {
  shareElem = document.getElementById('share');
  shareElem.remove();
});
            Severity: Minor
            Found in appedit.js and 1 other location - About 45 mins to fix
            appedit.js on lines 70..73

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function error has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function error(err, a, b, c, d) {
            Severity: Minor
            Found in appedit.js - About 35 mins to fix

              Function loadSourceCode has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              function loadSourceCode() {
  var repos = ss.getJS(['route', 'github']);
  var sourceHash = ss.getJS(['route', 'sourceHash']);
  ss.set('route.sourceHash');
  ss.set('route.github');
              Severity: Minor
              Found in appedit.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language