Sign upLogin

somleng/somleng-adhearsion

View on GitHub
Star

Showing 6 of 6 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

module EncryptedCredentials
  class EncryptedFile
    CIPHER = "aes-256-cbc".freeze
    DEFAULT_KEY_PATH = Pathname(File.expand_path("../config/master.key", __dir__))
    DEFAULT_FILE_PATH = Pathname(File.expand_path("../config/credentials.yml.enc", __dir__))
Severity: Major
Found in components/app/lib/encrypted_credentials.rb and 1 other location - About 5 hrs to fix
components/services/lib/encrypted_credentials.rb on lines 6..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 172.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

module EncryptedCredentials
  class EncryptedFile
    CIPHER = "aes-256-cbc".freeze
    DEFAULT_KEY_PATH = Pathname(File.expand_path("../config/master.key", __dir__))
    DEFAULT_FILE_PATH = Pathname(File.expand_path("../config/credentials.yml.enc", __dir__))
Severity: Major
Found in components/services/lib/encrypted_credentials.rb and 1 other location - About 5 hrs to fix
components/app/lib/encrypted_credentials.rb on lines 6..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 172.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method call has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  def call
    redirect_args = catch(:redirect) do
      twiml_document.twiml.each do |verb|
        next if verb.comment?
Severity: Minor
Found in components/app/app/workflows/execute_twiml.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method call has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def call
    redirect_args = catch(:redirect) do
      twiml_document.twiml.each do |verb|
        next if verb.comment?
Severity: Minor
Found in components/app/app/workflows/execute_twiml.rb - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        if (ws) {
      console.log(`${JSON.stringify(msg)}`)
      ws.send(JSON.stringify(msg))
    }
    Severity: Minor
    Found in components/testing/support/ws_server/test_server.js and 1 other location - About 55 mins to fix
    components/testing/support/ws_server/test_server.js on lines 40..43

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        if (ws) {
      console.log(`${JSON.stringify(msg)}`)
      ws.send(JSON.stringify(msg))
    }
    Severity: Minor
    Found in components/testing/support/ws_server/test_server.js and 1 other location - About 55 mins to fix
    components/testing/support/ws_server/test_server.js on lines 32..35

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language