Sign upLogin

songkick/dolphin

View on GitHub
Star

Showing 3 of 3 total issues

Method run has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def run
      raise "must define existing implementation" unless @existing
      existing_result = @existing.call
      if Dolphin.feature_available?(@experimental_feature_name)
        begin
Severity: Minor
Found in lib/dolphin/experiment.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def run
      raise "must define existing implementation" unless @existing
      existing_result = @existing.call
      if Dolphin.feature_available?(@experimental_feature_name)
        begin
Severity: Minor
Found in lib/dolphin/experiment.rb - About 1 hr to fix

    Method feature_available? has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.feature_available?(name)
    if feature_store
      if flipper_name = feature_store[name]
        if flipper = flipper_store[flipper_name]
          instance_eval(&flipper)
    Severity: Minor
    Found in lib/dolphin.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language