Sign upLogin

sosia-dev/sosia

View on GitHub
Star
sosia/classes/scientist.py

Summary

Maintainability
D
1 day
Test Coverage

Scientist has 42 functions (exceeds 20 allowed). Consider refactoring.
Open

class Scientist(object):
    @property
    def active_year(self):
        """The scientist's most recent year with publication(s) before
         provided year (which may be the same).
Severity: Minor
Found in sosia/classes/scientist.py - About 5 hrs to fix

    File scientist.py has 314 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    #!/usr/bin/env python
# -*- coding: utf-8 -*-
# Author:   Michael E. Rose <michael.ernst.rose@gmail.com>
"""Super class to represent a scientist."""
    Severity: Minor
    Found in sosia/classes/scientist.py - About 3 hrs to fix

      Function __init__ has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          def __init__(self, identifier, year, refresh=False, period=None, eids=None,
                 sql_fname=None):
        """Class to represent a scientist.

        Parameters
      Severity: Minor
      Found in sosia/classes/scientist.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __init__ has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def __init__(self, identifier, year, refresh=False, period=None, eids=None,
                 sql_fname=None):
        """Class to represent a scientist.

        Parameters
      Severity: Minor
      Found in sosia/classes/scientist.py - About 1 hr to fix

        Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(self, identifier, year, refresh=False, period=None, eids=None,
        Severity: Minor
        Found in sosia/classes/scientist.py - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status