Sign upLogin

sounisi5011/metalsmith-netlify-published-date

View on GitHub
Star

Showing 24 of 26 total issues

File lookup.ts has 686 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Metalsmith from 'metalsmith';
import { ObjectState } from 'object-rollback';
import { URL } from 'url';

import PreviewCache, { CachedPreviewResponseInterface } from './cache/preview';
Severity: Major
Found in src/lookup.ts - About 1 day to fix

    Function netlifyDeploys has a Cognitive Complexity of 67 (exceeds 5 allowed). Consider refactoring.
    Open

    export async function* netlifyDeploys(
    siteID: string,
    options: {
        accessToken?: string | null;
        commitHashList?: readonly string[];
    Severity: Minor
    Found in src/netlify.ts - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function netlifyDeploys has 153 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export async function* netlifyDeploys(
    siteID: string,
    options: {
        accessToken?: string | null;
        commitHashList?: readonly string[];
    Severity: Major
    Found in src/netlify.ts - About 6 hrs to fix

      Function convertReplace has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

      export function convertReplace({
    replace: schema,
}: {
    replace: unknown;
}): ReturnFuncType {
      Severity: Minor
      Found in src/options/filename2urlPath.ts - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getPreviewDataList has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

      export async function getPreviewDataList({
    targetFileList,
    files,
    dateStateMap,
    deploy,
      Severity: Minor
      Found in src/lookup.ts - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function redirectFetch has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

      export async function redirectFetch(
    requestURL: string | WHATWG_URL,
    options: FetchOptions = {},
    /** @see https://fetch.spec.whatwg.org/commit-snapshots/8ca61488c0c9efb32fd138ce14e25ce2b4ce0dfc/#http-redirect-fetch */
    maxRedirects = 20,
      Severity: Minor
      Found in src/utils/fetch.ts - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          if (!dateState.published.established) {
                        if (!dateState.modified.established) {
                            fileMetadataLog(
                                '%s / published date and modified date is established: %s / %s',
                                filename,
      Severity: Major
      Found in src/lookup.ts and 1 other location - About 2 hrs to fix
      src/lookup.ts on lines 773..788

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 81.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (!dateState.modified.established) {
            if (!dateState.published.established) {
                fileMetadataLog(
                    '%s / published date and modified date is established: %s / %s',
                    filename,
      Severity: Major
      Found in src/lookup.ts and 1 other location - About 2 hrs to fix
      src/lookup.ts on lines 381..396

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 81.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function fetch has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              (async (url, headers) => {
            requestLog('GET %s / headers %o', url, headers);
            const result = await redirectFetch(url, { headers }).catch(
                error => {
                    responseErrorLog(
      Severity: Major
      Found in src/netlify.ts - About 2 hrs to fix

        Function redirectFetch has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export async function redirectFetch(
    requestURL: string | WHATWG_URL,
    options: FetchOptions = {},
    /** @see https://fetch.spec.whatwg.org/commit-snapshots/8ca61488c0c9efb32fd138ce14e25ce2b4ce0dfc/#http-redirect-fetch */
    maxRedirects = 20,
        Severity: Minor
        Found in src/utils/fetch.ts - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              fileData.published = defaultDate2value({
        dateStr: metadata.published,
        defaultDate: options.defaultDate,
        nowDate,
        metadata: {
          Severity: Major
          Found in src/plugin.ts and 1 other location - About 1 hr to fix
          src/plugin.ts on lines 188..198

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              fileData.modified = defaultDate2value({
        dateStr: metadata.modified,
        defaultDate: options.defaultDate,
        nowDate,
        metadata: {
          Severity: Major
          Found in src/plugin.ts and 1 other location - About 1 hr to fix
          src/plugin.ts on lines 177..187

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function normalize has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function normalize(value: unknown): ReturnFuncType {
    if (typeof value === 'function') {
        return strReturnFunc(
            value,
            `The function set to option "${PROP}" did not return a string`,
          Severity: Minor
          Found in src/options/filename2urlPath.ts - About 1 hr to fix

            Function normalize has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

            export function normalize(value: unknown): ReturnFuncType {
    if (typeof value === 'function') {
        return strReturnFunc(
            value,
            `The function set to option "${PROP}" did not return a string`,
            Severity: Minor
            Found in src/options/filename2urlPath.ts - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function fetchPageData has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            export async function fetchPageData({
    filename,
    urlpath,
    previewPageURL,
    deploy,
            Severity: Minor
            Found in src/lookup.ts - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                                if (typeof value === 'string') {
                        return value;
                    }
            Severity: Major
            Found in src/options/filename2urlPath.ts - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  if (!matchedDeployList.includes(initialDeploy)) {
                        responseLog(
                            'get the initial deploy from the response / %s',
                            url,
                        );
              Severity: Major
              Found in src/netlify.ts - About 45 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (typeof value === 'function') {
        return typesafeFunc(
            value,
            Buffer.isBuffer,
            `The function set to option "${PROP}" did not return a Buffer`,
                Severity: Minor
                Found in src/options/contentsConverter.ts and 1 other location - About 40 mins to fix
                src/options/metadataUpdater.ts on lines 39..49

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (typeof value === 'function') {
        return voidReturnFunc(value);
    } else if (typeof value === 'string') {
        return importModule(value);
    } else {
                Severity: Minor
                Found in src/options/metadataUpdater.ts and 1 other location - About 40 mins to fix
                src/options/contentsConverter.ts on lines 43..57

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function convertMetadata has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                export function convertMetadata({
    metadata: schema,
}: {
    metadata: unknown;
}): ReturnFuncType {
                Severity: Minor
                Found in src/options/filename2urlPath.ts - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language