Sign upLogin

sounisi5011/semver-range-intersect

View on GitHub
Star

Showing 44 of 44 total issues

Function merge has a Cognitive Complexity of 88 (exceeds 5 allowed). Consider refactoring.
Open

    public merge(
        singleRange: SingleVer | SingleRange,
    ): SingleVer | SingleRange | null {
        if (semver.intersects(String(this), String(singleRange))) {
            if (singleRange instanceof SingleVer) {
Severity: Minor
Found in src/single-range.ts - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (!(semverA instanceof semver.SemVer)) {
                if (
                    !options.singleRange &&
                    isPrerelease(semverB) &&
                    !(
Severity: Major
Found in src/utils.ts and 1 other location - About 1 day to fix
src/utils.ts on lines 149..183

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 227.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (!(semverA instanceof semver.SemVer)) {
                if (
                    !options.singleRange &&
                    isPrerelease(semverB) &&
                    !(
Severity: Major
Found in src/utils.ts and 1 other location - About 1 day to fix
src/utils.ts on lines 262..296

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 227.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getUpperBoundComparator has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function getUpperBoundComparator(
    comparatorList: readonly semver.Comparator[],
    options: { singleRange?: boolean } = {},
): semver.Comparator {
    const validComparatorList = comparatorList.filter(
Severity: Major
Found in src/utils.ts - About 3 hrs to fix

    Function getLowerBoundComparator has 85 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function getLowerBoundComparator(
    comparatorList: readonly semver.Comparator[],
    options: { singleRange?: boolean } = {},
): semver.Comparator {
    const validComparatorList = comparatorList.filter(
    Severity: Major
    Found in src/utils.ts - About 3 hrs to fix

      Function merge has 82 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public merge(
        singleRange: SingleVer | SingleRange,
    ): SingleVer | SingleRange | null {
        if (semver.intersects(String(this), String(singleRange))) {
            if (singleRange instanceof SingleVer) {
      Severity: Major
      Found in src/single-range.ts - About 3 hrs to fix

        File utils.ts has 279 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        import semver from 'semver';

export function isNotNull<T>(value: T | null): value is T {
    return value !== null;
}
        Severity: Minor
        Found in src/utils.ts - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              if (a.operator === b.operator || semverCmp !== 0) {
                        // >2.0.0  / >3.0.0  ... >2.0.0
                        // >=1.0.0 / >=1.1.0 ... >=1.0.0
                        // >2.0.0  / >=2.0.1 ... >2.0.0
                        // >=2.0.1 / >2.0.0  ... >2.0.0
          Severity: Major
          Found in src/single-range.ts and 1 other location - About 2 hrs to fix
          src/single-range.ts on lines 217..237

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 87.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              if (a.operator === b.operator || semverCmp !== 0) {
                        // <2.0.0  / <3.0.0  ... <3.0.0
                        // <=1.0.0 / <=1.1.0 ... <=1.1.0
                        // <2.0.0  / <=2.0.1 ... <=2.0.1
                        // <=2.0.1 / <2.0.0  ... <=2.0.1
          Severity: Major
          Found in src/single-range.ts and 1 other location - About 2 hrs to fix
          src/single-range.ts on lines 159..179

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 87.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function normalizeSingleRangeList has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function normalizeSingleRangeList(
    singleRangeList: readonly (SingleVer | SingleRange | null)[],
): readonly (SingleVer | SingleRange | null)[] {
    return singleRangeList.reduce(
        (singleRangeList, singleRange) => {
          Severity: Minor
          Found in src/multi-range.ts - About 1 hr to fix

            Function intersect has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public intersect(
        singleRange: SingleVer | SingleRange,
    ): SingleVer | SingleRange | null {
        if (semver.intersects(String(this), String(singleRange))) {
            if (singleRange instanceof SingleVer) {
            Severity: Minor
            Found in src/single-range.ts - About 1 hr to fix

              Function lowerBound has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                              const lowerBound = ((a, b) => {
                    const semverA: semver.SemVer | {} = a.semver;
                    const semverB: semver.SemVer | {} = b.semver;

                    // >2.0.0      / *           ... *
              Severity: Minor
              Found in src/single-range.ts - About 1 hr to fix

                Function upperBound has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                                const upperBound = ((a, b) => {
                    const semverA: semver.SemVer | {} = a.semver;
                    const semverB: semver.SemVer | {} = b.semver;

                    // <2.0.0      / *           ... *
                Severity: Minor
                Found in src/single-range.ts - About 1 hr to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          if (semverCmpMain < 0) {
                            return new semver.Comparator(
                                `<${stripSemVerPrerelease(semverA)}`,
                                a.options,
                            );
                  Severity: Major
                  Found in src/utils.ts - About 45 mins to fix

                    Function intersect has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public intersect(
        singleRange: SingleVer | SingleRange,
    ): SingleVer | SingleRange | null {
        if (semver.intersects(String(this), String(singleRange))) {
            if (singleRange instanceof SingleVer) {
                    Severity: Minor
                    Found in src/single-range.ts - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid deeply nested control flow statements.
                    Open

                                            if (semverCmpMain > 0) {
                            return new semver.Comparator(
                                a.operator + stripSemVerPrerelease(semverA),
                                a.options,
                            );
                    Severity: Major
                    Found in src/utils.ts - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                              if (isPrerelease(semverA)) {
                            return null;
                        }
                      Severity: Major
                      Found in src/single-range.ts - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                if (isPrerelease(semverA)) {
                            return null;
                        }
                        Severity: Major
                        Found in src/single-range.ts - About 45 mins to fix

                          Function constructor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public constructor(
        rangeList:
            | (readonly (
                  | SingleVer
                  | SingleRange
                          Severity: Minor
                          Found in src/multi-range.ts - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Avoid too many return statements within this function.
                          Open

                                              return a;
                          Severity: Major
                          Found in src/utils.ts - About 30 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language