Sign upLogin

sovereignbot/citadel

View on GitHub
Star
src/Plugins/onMessage/eightball.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
Severity: Major
Found in src/Plugins/onMessage/eightball.php - About 1 hr to fix

Method run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run()
    {
        $choices = array(
            'It is certain',
            'It is decidedly so',
Severity: Minor
Found in src/Plugins/onMessage/eightball.php - About 1 hr to fix

The method __construct has 12 parameters. Consider reducing the number of parameters to less than 10.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
    {
        $this->message = $message;
        $this->discord = $discord;
        $this->channelConfig = $channelConfig;
Severity: Minor
Found in src/Plugins/onMessage/eightball.php by phpmd

Identical blocks of code found in 17 locations. Consider refactoring.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
    {
        $this->message = $message;
        $this->discord = $discord;
        $this->channelConfig = $channelConfig;
Severity: Major
Found in src/Plugins/onMessage/eightball.php and 16 other locations - About 3 hrs to fix
src/Plugins/onMessage/about.php on lines 68..82
src/Plugins/onMessage/auth.php on lines 69..83
src/Plugins/onMessage/char.php on lines 67..81
src/Plugins/onMessage/coinflip.php on lines 67..81
src/Plugins/onMessage/config.php on lines 66..80
src/Plugins/onMessage/corp.php on lines 67..81
src/Plugins/onMessage/guilds.php on lines 68..82
src/Plugins/onMessage/join.php on lines 67..81
src/Plugins/onMessage/meme.php on lines 67..81
src/Plugins/onMessage/memory.php on lines 67..81
src/Plugins/onMessage/pc.php on lines 68..82
src/Plugins/onMessage/porn.php on lines 67..81
src/Plugins/onMessage/time.php on lines 69..83
src/Plugins/onMessage/tq.php on lines 67..81
src/Plugins/onMessage/user.php on lines 67..81
src/Plugins/onMessage/wolf.php on lines 67..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 160.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

The class eightball is not named in CamelCase.
Open

class eightball extends \Threaded implements \Collectable
{
    /**
     * @var Message
     */
Severity: Minor
Found in src/Plugins/onMessage/eightball.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    private $db;
Severity: Minor
Found in src/Plugins/onMessage/eightball.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
Severity: Minor
Found in src/Plugins/onMessage/eightball.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status