Sign upLogin

sparkapi/spark_api

View on GitHub
Star
lib/spark_api/request.rb

Summary

Maintainability
C
1 day
Test Coverage

Method request has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    def request(method, path, body, options)
      unless authenticated?
        authenticate
      end
Severity: Minor
Found in lib/spark_api/request.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method request has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def request(method, path, body, options)
      unless authenticated?
        authenticate
      end
Severity: Major
Found in lib/spark_api/request.rb - About 2 hrs to fix

    Method process_request_body has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def process_request_body(body)
      if body.is_a?(Hash) || body.is_a?(Array)
        body.empty? ? nil : {"D" => body }.to_json
      else
        body
    Severity: Minor
    Found in lib/spark_api/request.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status