Sign upLogin

sparklemotion/nokogiri

View on GitHub
Star
ext/java/nokogiri/XmlNamespace.java

Summary

Maintainability
A
2 hrs
Test Coverage

Method createImpl has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  createImpl(Node owner, IRubyObject prefix, String prefixStr, IRubyObject href, String hrefStr)
Severity: Minor
Found in ext/java/nokogiri/XmlNamespace.java - About 35 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      @JRubyMethod
  public IRubyObject
  href(ThreadContext context)
  {
    if (hrefRuby == null) {
    Severity: Minor
    Found in ext/java/nokogiri/XmlNamespace.java and 1 other location - About 40 mins to fix
    ext/java/nokogiri/XmlNamespace.java on lines 168..177

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      @JRubyMethod
  public IRubyObject
  prefix(ThreadContext context)
  {
    if (prefixRuby == null) {
    Severity: Minor
    Found in ext/java/nokogiri/XmlNamespace.java and 1 other location - About 40 mins to fix
    ext/java/nokogiri/XmlNamespace.java on lines 157..166

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status