Sign upLogin

sparklemotion/nokogiri

View on GitHub
Star
ext/java/nokogiri/internals/NokogiriHandler.java

Summary

Maintainability
C
1 day
Test Coverage

Method startElement has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  @Override
  public void
  startElement(String uri, String localName, String qName, Attributes attrs) throws SAXException
  {
    final Ruby runtime = this.runtime;
Severity: Minor
Found in ext/java/nokogiri/internals/NokogiriHandler.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

NokogiriHandler has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

public class NokogiriHandler extends DefaultHandler2 implements XmlDeclHandler
{

  StringBuilder charactersBuilder;
  private final Ruby runtime;
Severity: Minor
Found in ext/java/nokogiri/internals/NokogiriHandler.java - About 3 hrs to fix

    File NokogiriHandler.java has 278 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package nokogiri.internals;

import static nokogiri.internals.NokogiriHelpers.getLocalPart;
import static nokogiri.internals.NokogiriHelpers.getPrefix;
import static nokogiri.internals.NokogiriHelpers.isNamespace;
    Severity: Minor
    Found in ext/java/nokogiri/internals/NokogiriHandler.java - About 2 hrs to fix

      Method startElement has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        @Override
  public void
  startElement(String uri, String localName, String qName, Attributes attrs) throws SAXException
  {
    final Ruby runtime = this.runtime;
      Severity: Minor
      Found in ext/java/nokogiri/internals/NokogiriHandler.java - About 1 hr to fix

        Method call has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          call(String methodName,
       IRubyObject arg0,
       IRubyObject arg1,
       IRubyObject arg2,
       IRubyObject arg3,
        Severity: Minor
        Found in ext/java/nokogiri/internals/NokogiriHandler.java - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            static
  {
    final String[] emptyAttrs = {
      "checked", "compact", "declare", "defer", "disabled", "ismap", "multiple",
      "noresize", "nohref", "noshade", "nowrap", "readonly", "selected"
          Severity: Minor
          Found in ext/java/nokogiri/internals/NokogiriHandler.java and 1 other location - About 40 mins to fix
          ext/java/nokogiri/internals/SaveContextVisitor.java on lines 276..284

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status