Sign upLogin

sparklemotion/nokogiri

View on GitHub
Star
ext/java/nokogiri/internals/NokogiriXPathFunction.java

Summary

Maintainability
C
7 hrs
Test Coverage

Method builtinCssClass has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  private static boolean
  builtinCssClass(List<?> args) throws XPathFunctionException
  {
    if (args.size() != 2) {
      throw new XPathFunctionException("builtin function nokogiri:css-class takes two arguments");
Severity: Minor
Found in ext/java/nokogiri/internals/NokogiriXPathFunction.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method builtinCssClass has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private static boolean
  builtinCssClass(List<?> args) throws XPathFunctionException
  {
    if (args.size() != 2) {
      throw new XPathFunctionException("builtin function nokogiri:css-class takes two arguments");
Severity: Minor
Found in ext/java/nokogiri/internals/NokogiriXPathFunction.java - About 1 hr to fix

    Method fromRubyToObject has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      private static Object
  fromRubyToObject(final Ruby runtime, IRubyObject obj)
  {
    if (obj instanceof RubyString) { return obj.asJavaString(); }
    if (obj instanceof RubyBoolean) { return obj.toJava(Boolean.class); }
    Severity: Minor
    Found in ext/java/nokogiri/internals/NokogiriXPathFunction.java - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

          return obj.toJava(java.math.BigInteger.class);
    Severity: Major
    Found in ext/java/nokogiri/internals/NokogiriXPathFunction.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          if (obj instanceof XmlNodeSet) { return obj; }
      Severity: Major
      Found in ext/java/nokogiri/internals/NokogiriXPathFunction.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return XmlNodeSet.newNodeSet(runtime, ((RubyArray) obj).toJavaArray());
        Severity: Major
        Found in ext/java/nokogiri/internals/NokogiriXPathFunction.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              /*if (o instanceof XmlNode)*/ return ((XmlNode) obj).getNode();
          Severity: Major
          Found in ext/java/nokogiri/internals/NokogiriXPathFunction.java - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                for (int i = 0; i < args.size(); i++) {
      newArgs[i] = fromObjectToRuby(runtime, args.get(i));
    }
            Severity: Minor
            Found in ext/java/nokogiri/internals/NokogiriXPathFunction.java and 1 other location - About 30 mins to fix
            ext/java/nokogiri/Html4ElementDescription.java on lines 126..128

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 42.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status