Sign upLogin

sparklemotion/nokogiri

View on GitHub
Star
ext/java/nokogiri/internals/c14n/UtfHelpper.java

Summary

Maintainability
D
1 day
Test Coverage

Method getStringInUtf8 has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  public static byte[]
  getStringInUtf8(final String str)
  {
    final int length = str.length();
    boolean expanded = false;
Severity: Minor
Found in ext/java/nokogiri/internals/c14n/UtfHelpper.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method writeStringToUtf8 has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  public static void
  writeStringToUtf8(
    final String str,
    final OutputStream out
  ) throws IOException
Severity: Minor
Found in ext/java/nokogiri/internals/c14n/UtfHelpper.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getStringInUtf8 has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public static byte[]
  getStringInUtf8(final String str)
  {
    final int length = str.length();
    boolean expanded = false;
Severity: Major
Found in ext/java/nokogiri/internals/c14n/UtfHelpper.java - About 2 hrs to fix

    Method writeStringToUtf8 has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public static void
  writeStringToUtf8(
    final String str,
    final OutputStream out
  ) throws IOException
    Severity: Minor
    Found in ext/java/nokogiri/internals/c14n/UtfHelpper.java - About 1 hr to fix

      Method writeCharToUtf8 has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        public static void
  writeCharToUtf8(final char c, final OutputStream out) throws IOException
  {
    if (c < 0x80) {
      out.write(c);
      Severity: Minor
      Found in ext/java/nokogiri/internals/c14n/UtfHelpper.java - About 1 hr to fix

        Method writeCharToUtf8 has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          public static void
  writeCharToUtf8(final char c, final OutputStream out) throws IOException
  {
    if (c < 0x80) {
      out.write(c);
        Severity: Minor
        Found in ext/java/nokogiri/internals/c14n/UtfHelpper.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              if (c > 0x07FF) {
        ch = (char)(c >>> 12);
        write = 0xE0;
        if (ch > 0) {
          write |= (ch & 0x0F);
        Severity: Major
        Found in ext/java/nokogiri/internals/c14n/UtfHelpper.java and 1 other location - About 1 hr to fix
        ext/java/nokogiri/internals/c14n/UtfHelpper.java on lines 65..77

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            if (c > 0x07FF) {
      ch = (char)(c >>> 12);
      write = 0xE0;
      if (ch > 0) {
        write |= (ch & 0x0F);
        Severity: Major
        Found in ext/java/nokogiri/internals/c14n/UtfHelpper.java and 1 other location - About 1 hr to fix
        ext/java/nokogiri/internals/c14n/UtfHelpper.java on lines 110..122

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 100.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status