sparklemotion/nokogiri

View on GitHub

Showing 539 of 539 total issues

Method native_write has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  @JRubyMethod
  public IRubyObject
  native_write(ThreadContext context, IRubyObject chunk,
               IRubyObject isLast)
  {
Severity: Minor
Found in ext/java/nokogiri/XmlSaxPushParser.java - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getStrFromNode has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  public static String
  getStrFromNode(Node xpathnode)
  {
    if (xpathnode.getNodeType() == Node.TEXT_NODE) {
      // we iterate over all siblings of the context node because eventually,
Severity: Minor
Found in ext/java/nokogiri/internals/c14n/XMLUtils.java - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                if (childElement.hasAttributeNS(namespaceNs,
                                                currentAttr.getLocalName())) {
                  continue;
                }
Severity: Major
Found in ext/java/nokogiri/internals/c14n/XMLUtils.java - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                if (prefix != null && !(prefix.equals(XML) || prefix.equals(XMLNS))) {
                  visiblyUtilized.add(prefix);
                }
    Severity: Major
    Found in ext/java/nokogiri/internals/c14n/Canonicalizer20010315Excl.java - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                      if (!namespaceNs.equals(currentAttr.getNamespaceURI())) {
                        continue;
                      }
      Severity: Major
      Found in ext/java/nokogiri/internals/c14n/XMLUtils.java - About 45 mins to fix

        Method findNamespaceHref has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          private String
          findNamespaceHref(ThreadContext context, String prefix)
          {
            XmlNode currentNode = this;
            final XmlDocument doc = document(context.runtime);
        Severity: Minor
        Found in ext/java/nokogiri/XmlNode.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getAttrsOfAncestors has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          private void
          getAttrsOfAncestors(Node parent, List<Attr> namespaces, List<Attr> attributes)
          {
            if (parent == null) { return; }
            NamedNodeMap attrs = parent.getAttributes();
        Severity: Minor
        Found in ext/java/nokogiri/internals/SaveContextVisitor.java - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                    if (NName.equals("id")) {
                      if (isRealVisible) {
                        // treat xml:id like any other attribute
                        // (emit it, but don't inherit it)
                        result.add(attribute);
        Severity: Major
        Found in ext/java/nokogiri/internals/c14n/Canonicalizer11.java - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                        if (specifiedPrefix == null &&
                            attr.getNodeName().equals("xmlns")) {
                          // default namespace
                          return value;
                        } else if (attrPrefix != null &&

            Avoid deeply nested control flow statements.
            Open

                        for (int k = 0; k < nodeMap.getLength(); k++) {
                          if ("charset".equalsIgnoreCase((item = nodeMap.item(k)).getNodeName())) {
                            return item.getNodeValue();
                          }
                        }
            Severity: Major
            Found in ext/java/nokogiri/internals/HtmlDomParserContext.java - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                          if (!m_processedFirstElement
                              && "xmlns:xml".equals(attrs.item(i).getNodeName())) {
                            m_processedFirstElement = true;
                          }
              Severity: Major
              Found in ext/java/nokogiri/internals/dom2dtm/DOM2DTM.java - About 45 mins to fix

                Method getNodeValue has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                  public String
                  getNodeValue(int nodeHandle)
                  {
                    // The _type(nodeHandle) call was taking the lion's share of our
                    // time, and was wrong anyway since it wasn't converting handle to
                Severity: Minor
                Found in ext/java/nokogiri/internals/dom2dtm/DOM2DTM.java - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method call has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  call(String methodName,
                       IRubyObject arg0,
                       IRubyObject arg1,
                       IRubyObject arg2,
                       IRubyObject arg3,
                Severity: Minor
                Found in ext/java/nokogiri/internals/NokogiriHandler.java - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                              if (node == elem) {
                                elemHandle = getHandleFromNode(elem);
                                break;
                              }
                  Severity: Major
                  Found in ext/java/nokogiri/internals/dom2dtm/DOM2DTM.java - About 45 mins to fix

                    Method configure has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                                def configure
                                  Dir.chdir(work_path) do
                                    mk = File.read("win32/Makefile.gcc")
                                    File.open("win32/Makefile.gcc", "wb") do |f|
                                      f.puts "BINARY_PATH = #{path}/bin"
                    Severity: Minor
                    Found in ext/nokogiri/extconf.rb - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid deeply nested control flow statements.
                    Open

                                  if darwin?
                                    # needed as of zlib 1.2.13
                                    Dir.chdir(work_path) do
                                      makefile = File.read("Makefile").gsub(/^AR=.*$/, "AR=#{host}-libtool")
                                      File.open("Makefile", "w") { |m| m.write(makefile) }
                    Severity: Major
                    Found in ext/nokogiri/extconf.rb - About 45 mins to fix

                      Method read_and_encode has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                            def read_and_encode(string, encoding)
                              # Read the string with the given encoding.
                              if string.respond_to?(:read)
                                string = if encoding.nil?
                                  string.read
                      Severity: Minor
                      Found in lib/nokogiri/html5.rb - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method visit_attribute_condition has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                            def visit_attribute_condition(node)
                              attribute = node.value.first.accept(self)
                              return attribute if node.value.length == 1
                      
                              value = node.value.last
                      Severity: Minor
                      Found in lib/nokogiri/css/xpath_visitor.rb - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Avoid deeply nested control flow statements.
                      Open

                                        mk.sub!(/^PREFIX\s*=\s*$/, "PREFIX = #{host}-") if cross_build_p
                      Severity: Major
                      Found in ext/nokogiri/extconf.rb - About 45 mins to fix

                        Method stabilizeAttrs has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                          private static void
                          stabilizeAttrs(Node node)
                          {
                            if (node.hasAttributes()) {
                              NamedNodeMap nodeMap = node.getAttributes();
                        Severity: Minor
                        Found in ext/java/nokogiri/Html4Document.java - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language