sparklemotion/nokogiri

View on GitHub

Showing 537 of 537 total issues

Similar blocks of code found in 8 locations. Consider refactoring.
Open

      case Node.ATTRIBUTE_NODE:
        XmlAttr xmlAttr = (XmlAttr) NokogiriService.XML_ATTR_ALLOCATOR.allocate(runtime, getNokogiriClass(runtime,
                          "Nokogiri::XML::Attr"));
        xmlAttr.setNode(runtime, node);
        return xmlAttr;
Severity: Major
Found in ext/java/nokogiri/internals/NokogiriHelpers.java and 7 other locations - About 30 mins to fix
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 119..123
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 129..133
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 134..138
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 141..145
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 146..151
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 152..156
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 162..166

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

      case Node.ENTITY_REFERENCE_NODE:
        XmlEntityReference xmlEntityRef = (XmlEntityReference) NokogiriService.XML_ENTITY_REFERENCE_ALLOCATOR.allocate(runtime,
                                          getNokogiriClass(runtime, "Nokogiri::XML::EntityReference"));
        xmlEntityRef.setNode(runtime, node);
        return xmlEntityRef;
Severity: Major
Found in ext/java/nokogiri/internals/NokogiriHelpers.java and 7 other locations - About 30 mins to fix
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 119..123
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 124..128
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 129..133
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 134..138
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 146..151
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 152..156
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 162..166

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    for (int i = 0; i < args.size(); i++) {
      newArgs[i] = fromObjectToRuby(runtime, args.get(i));
    }
Severity: Minor
Found in ext/java/nokogiri/internals/NokogiriXPathFunction.java and 1 other location - About 30 mins to fix
ext/java/nokogiri/Html4ElementDescription.java on lines 126..128

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

      case Node.TEXT_NODE:
        XmlText xmlText = (XmlText) NokogiriService.XML_TEXT_ALLOCATOR.allocate(runtime, getNokogiriClass(runtime,
                          "Nokogiri::XML::Text"));
        xmlText.setNode(runtime, node);
        return xmlText;
Severity: Major
Found in ext/java/nokogiri/internals/NokogiriHelpers.java and 7 other locations - About 30 mins to fix
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 119..123
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 124..128
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 134..138
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 141..145
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 146..151
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 152..156
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 162..166

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

      case Node.PROCESSING_INSTRUCTION_NODE:
        XmlProcessingInstruction xmlProcessingInstruction = (XmlProcessingInstruction)
            NokogiriService.XML_PROCESSING_INSTRUCTION_ALLOCATOR.allocate(runtime, getNokogiriClass(runtime,
                "Nokogiri::XML::ProcessingInstruction"));
        xmlProcessingInstruction.setNode(runtime, node);
Severity: Major
Found in ext/java/nokogiri/internals/NokogiriHelpers.java and 7 other locations - About 30 mins to fix
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 119..123
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 124..128
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 129..133
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 134..138
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 141..145
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 152..156
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 162..166

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

      case Node.DOCUMENT_TYPE_NODE:
        XmlDtd xmlDtd = (XmlDtd) NokogiriService.XML_DTD_ALLOCATOR.allocate(runtime, getNokogiriClass(runtime,
                        "Nokogiri::XML::DTD"));
        xmlDtd.setNode(runtime, node);
        return xmlDtd;
Severity: Major
Found in ext/java/nokogiri/internals/NokogiriHelpers.java and 7 other locations - About 30 mins to fix
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 119..123
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 124..128
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 129..133
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 134..138
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 141..145
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 146..151
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 152..156

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

      case Node.ELEMENT_NODE:
        XmlElement xmlElement = (XmlElement) NokogiriService.XML_ELEMENT_ALLOCATOR.allocate(runtime, getNokogiriClass(runtime,
                                "Nokogiri::XML::Element"));
        xmlElement.setNode(runtime, node);
        return xmlElement;
Severity: Major
Found in ext/java/nokogiri/internals/NokogiriHelpers.java and 7 other locations - About 30 mins to fix
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 124..128
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 129..133
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 134..138
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 141..145
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 146..151
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 152..156
ext/java/nokogiri/internals/NokogiriHelpers.java on lines 162..166

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      try {
        Future<Void> task = stream.addChunk(data);
        task.get();
      } catch (ClosedStreamException ex) {
        // this means the stream is closed, ignore this exception
Severity: Minor
Found in ext/java/nokogiri/Html4SaxPushParser.java and 1 other location - About 30 mins to fix
ext/java/nokogiri/XmlSaxPushParser.java on lines 141..148

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    for (int i = 0; i < subs.size(); ++i) {
      ary[i] = ruby.newString(subs.get(i));
    }
Severity: Minor
Found in ext/java/nokogiri/Html4ElementDescription.java and 1 other location - About 30 mins to fix
ext/java/nokogiri/internals/NokogiriXPathFunction.java on lines 82..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

        return xmlDtd;
Severity: Major
Found in ext/java/nokogiri/internals/NokogiriHelpers.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

        return NokogiriHelpers.nkf(context, encoding, str);
    Severity: Major
    Found in ext/java/nokogiri/internals/NokogiriHelpers.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return enter((ProcessingInstruction)node);
      Severity: Major
      Found in ext/java/nokogiri/internals/SaveContextVisitor.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return context.runtime.newFixnum(-2);
        Severity: Major
        Found in ext/java/nokogiri/XmlNode.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return (attr0.getLocalName()).compareTo(attr1.getLocalName());
          Severity: Major
          Found in ext/java/nokogiri/internals/c14n/AttrCompare.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return xmlProcessingInstruction;
            Severity: Major
            Found in ext/java/nokogiri/internals/NokogiriHelpers.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return;
              Severity: Major
              Found in ext/java/nokogiri/internals/SaveContextVisitor.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return false;

                  Avoid too many return statements within this method.
                  Open

                        return;
                  Severity: Major
                  Found in ext/java/nokogiri/internals/SaveContextVisitor.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                          return;
                    Severity: Major
                    Found in ext/java/nokogiri/internals/SaveContextVisitor.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                          return s;
                      Severity: Major
                      Found in ext/java/nokogiri/internals/NokogiriEntityResolver.java - About 30 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language