Sign upLogin

sparklemotion/nokogiri

View on GitHub
Star

Showing 537 of 537 total issues

File DOM2DTMdefaultNamespaceDeclarationNode.java has 275 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * Copyright 1999-2004 The Apache Software Foundation.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
Severity: Minor
Found in ext/java/nokogiri/internals/dom2dtm/DOM2DTMdefaultNamespaceDeclarationNode.java - About 2 hrs to fix

    Method getStringInUtf8 has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

      public static byte[]
  getStringInUtf8(final String str)
  {
    final int length = str.length();
    boolean expanded = false;
    Severity: Minor
    Found in ext/java/nokogiri/internals/c14n/UtfHelper.java - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method joinURI has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private static String
  joinURI(String baseURI, String relativeURI) throws URISyntaxException
  {
    String bscheme = null;
    String bauthority = null;
    Severity: Major
    Found in ext/java/nokogiri/internals/c14n/Canonicalizer11.java - About 2 hrs to fix

      Method handleAttributes has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        @Override
  protected Iterator<Attr>
  handleAttributes(Element element, NameSpaceSymbTable ns)
  throws CanonicalizationException
  {
      Severity: Major
      Found in ext/java/nokogiri/internals/c14n/Canonicalizer11.java - About 2 hrs to fix

        Method addNode has 63 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          protected int
  addNode(Node node, int parentIndex,
          int previousSibling, int forceNodeType)
  {
    int nodeIndex = m_nodes.size();
        Severity: Major
        Found in ext/java/nokogiri/internals/dom2dtm/DOM2DTM.java - About 2 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  } else if (!XML.equals(NName) || !XML_LANG_URI.equals(NValue)) {
          /* except omit namespace node with local name xml, which defines
           * the xml prefix, if its string value is http://www.w3.org/XML/1998/namespace.
           */
          //add the prefix binding to the ns symb table.
          Severity: Major
          Found in ext/java/nokogiri/internals/c14n/Canonicalizer20010315.java and 1 other location - About 2 hrs to fix
          ext/java/nokogiri/internals/c14n/Canonicalizer11.java on lines 330..357

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 158.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  } else if (!XML.equals(NName) || !XML_LANG_URI.equals(NValue)) {
          /* except omit namespace node with local name xml, which defines
           * the xml prefix, if its string value is
           * http://www.w3.org/XML/1998/namespace.
           */
          Severity: Major
          Found in ext/java/nokogiri/internals/c14n/Canonicalizer11.java and 1 other location - About 2 hrs to fix
          ext/java/nokogiri/internals/c14n/Canonicalizer20010315.java on lines 297..323

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 158.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method getAttributeNode has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
          Open

            public int
  getAttributeNode(int nodeHandle, String namespaceURI,
                   String name)
  {
          Severity: Minor
          Found in ext/java/nokogiri/internals/dom2dtm/DOM2DTM.java - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getUnparsedEntityURI has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
          Open

            public String
  getUnparsedEntityURI(String name)
  {

    String url = "";
          Severity: Minor
          Found in ext/java/nokogiri/internals/dom2dtm/DOM2DTM.java - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method compile has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
          Open

                def compile
        cflags = concat_flags(ENV["CFLAGS"], "-fPIC", "-O2", "-g")

        env = { "CC" => gcc_cmd, "CFLAGS" => cflags }
        if config_cross_build?
          Severity: Minor
          Found in ext/nokogiri/extconf.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Class Document has 22 methods (exceeds 20 allowed). Consider refactoring.
          Open

              class Document < Nokogiri::XML::Node
      # See http://www.w3.org/TR/REC-xml-names/#ns-decl for more details. Note that we're not
      # attempting to handle unicode characters partly because libxml2 doesn't handle unicode
      # characters in NCNAMEs.
      NCNAME_START_CHAR = "A-Za-z_"
          Severity: Minor
          Found in lib/nokogiri/xml/document.rb - About 2 hrs to fix

            Method handleAttributes has 57 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              @Override
  protected Iterator<Attr>
  handleAttributes(Element element, NameSpaceSymbTable ns)
  throws CanonicalizationException
  {
            Severity: Major
            Found in ext/java/nokogiri/internals/c14n/Canonicalizer20010315.java - About 2 hrs to fix

              Method visit_function has 57 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    def visit_function(node)
        msg = :"visit_function_#{node.value.first.gsub(/[(]/, "")}"
        return send(msg, node) if respond_to?(msg)

        case node.value.first
              Severity: Major
              Found in lib/nokogiri/css/xpath_visitor.rb - About 2 hrs to fix

                File XmlSaxParserContext.java has 261 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                package nokogiri;

import nokogiri.internals.*;
import static nokogiri.internals.NokogiriHelpers.rubyStringToString;
                Severity: Minor
                Found in ext/java/nokogiri/XmlSaxParserContext.java - About 2 hrs to fix

                  File Canonicalizer20010315.java has 261 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  /**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements. See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership. The ASF licenses this file
                  Severity: Minor
                  Found in ext/java/nokogiri/internals/c14n/Canonicalizer20010315.java - About 2 hrs to fix

                    Method outputPItoWriter has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                    Open

                      protected void
  outputPItoWriter(
    ProcessingInstruction currentPI, OutputStream writer, int position
  ) throws IOException
  {
                    Severity: Minor
                    Found in ext/java/nokogiri/internals/c14n/CanonicalizerBase.java - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method getHandleOfNode has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                    Open

                      public int
  getHandleOfNode(Node node)
  {
    if (null != node) {
      // Is Node actually within the same document? If not, don't search!
                    Severity: Minor
                    Found in ext/java/nokogiri/internals/dom2dtm/DOM2DTM.java - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method getElementById has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                    Open

                      public int
  getElementById(String elementId)
  {

    Document doc = (m_root.getNodeType() == Node.DOCUMENT_NODE)
                    Severity: Minor
                    Found in ext/java/nokogiri/internals/dom2dtm/DOM2DTM.java - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method resolveEntity has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                    Open

                      protected InputSource
  resolveEntity(Ruby runtime, String name, String publicId, String baseURI, String systemId)
  throws IOException, SAXException
  {
    InputSource s = new InputSource();
                    Severity: Minor
                    Found in ext/java/nokogiri/internals/NokogiriEntityResolver.java - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method count has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                    Open

                      private boolean
  count(Node node, int[] counter)
  {
    if (node == this.node) {
      return true;
                    Severity: Minor
                    Found in ext/java/nokogiri/XmlNode.java - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language