Sign upLogin

sparklemotion/nokogiri

View on GitHub
Star
lib/nokogiri/html5.rb

Summary

Maintainability
B
5 hrs
Test Coverage
C
75%

Method reencode has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

      def reencode(body, content_type = nil)
        if body.encoding == Encoding::ASCII_8BIT
          encoding = nil

          # look for a Byte Order Mark (BOM)
Severity: Minor
Found in lib/nokogiri/html5.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method reencode has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def reencode(body, content_type = nil)
        if body.encoding == Encoding::ASCII_8BIT
          encoding = nil

          # look for a Byte Order Mark (BOM)
Severity: Minor
Found in lib/nokogiri/html5.rb - About 1 hr to fix

    Method read_and_encode has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def read_and_encode(string, encoding)
        # Read the string with the given encoding.
        if string.respond_to?(:read)
          string = if encoding.nil?
            string.read
    Severity: Minor
    Found in lib/nokogiri/html5.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parse has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def parse(string, url = nil, encoding = nil, **options, &block)
    Severity: Minor
    Found in lib/nokogiri/html5.rb - About 35 mins to fix

      Method HTML5 has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def self.HTML5(input, url = nil, encoding = nil, **options, &block)
      Severity: Minor
      Found in lib/nokogiri/html5.rb - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status