sparklemotion/nokogiri

View on GitHub
lib/nokogiri/html5/document.rb

Summary

Maintainability
A
2 hrs
Test Coverage
A
96%

Method parse has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

        def parse(string_or_io, url = nil, encoding = nil, **options, &block)
          yield options if block
          string_or_io = "" unless string_or_io

          if string_or_io.respond_to?(:encoding) && string_or_io.encoding != Encoding::ASCII_8BIT
Severity: Minor
Found in lib/nokogiri/html5/document.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def parse(string_or_io, url = nil, encoding = nil, **options, &block)
Severity: Minor
Found in lib/nokogiri/html5/document.rb - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status