Sign upLogin

sparkletown/sparkle

View on GitHub
Star
scripts/resize-images.ts

Summary

Maintainability
D
2 days
Test Coverage

Function main has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

const main = async () => {
  const bucket = admin.storage().bucket();
  console.log("Fetching files from bucket...");
  const res = await bucket.getFiles({ directory: "users" });
  const files = res[0];
Severity: Minor
Found in scripts/resize-images.ts - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function main has 103 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const main = async () => {
  const bucket = admin.storage().bucket();
  console.log("Fetching files from bucket...");
  const res = await bucket.getFiles({ directory: "users" });
  const files = res[0];
Severity: Major
Found in scripts/resize-images.ts - About 4 hrs to fix

Function resizeImage has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    const resizeImage = async () => {
      if (file.metadata.size <= MAX_SIZE_BYTES) {
        console.log(
          `Skipping ${file.name} - size is ${file.metadata.size}, <= ${MAX_SIZE_BYTES}`
        );
Severity: Major
Found in scripts/resize-images.ts - About 2 hrs to fix

Function backupFile has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const backupFile = async (
  remotePath: string,
  signedUrl: string,
  contentType: string
) => {
Severity: Minor
Found in scripts/resize-images.ts - About 1 hr to fix

Function backupFile has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

const backupFile = async (
  remotePath: string,
  signedUrl: string,
  contentType: string
) => {
Severity: Minor
Found in scripts/resize-images.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

      return await jimpImage.writeAsync(backuplocation);
Severity: Major
Found in scripts/resize-images.ts - About 30 mins to fix

Avoid too many return statements within this function.
Open

    return;
Severity: Major
Found in scripts/resize-images.ts - About 30 mins to fix

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      if ("headers" in response && "location" in response.headers) {
        console.error(`Got redirect to ${response.headers.location}; skipping`);
        return;
      }
Severity: Minor
Found in scripts/resize-images.ts and 1 other location - About 50 mins to fix
scripts/resize-images.ts on lines 186..191

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if ("headers" in response && "location" in response.headers) {
          console.error(
            `Got redirect to ${response.headers.location}; skipping`
          );
          return;
Severity: Minor
Found in scripts/resize-images.ts and 1 other location - About 50 mins to fix
scripts/resize-images.ts on lines 99..102

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      if (typeof response.body !== "object" || Buffer.isBuffer(response.body)) {
        const msg =
          "Could not load Buffer from <" +
          signedUrl +
          "> " +
Severity: Minor
Found in scripts/resize-images.ts and 1 other location - About 35 mins to fix
scripts/resize-images.ts on lines 193..206

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (
          typeof response.body !== "object" ||
          !Buffer.isBuffer(response.body)
        ) {
          const msg =
Severity: Minor
Found in scripts/resize-images.ts and 1 other location - About 35 mins to fix
scripts/resize-images.ts on lines 104..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status