Sign upLogin

sparkletown/sparkle

View on GitHub
Star
src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts

Summary

Maintainability
F
5 days
Test Coverage

File EntityFactory.ts has 509 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Engine, Entity, NodeList } from "@ash.ts/ash";
import { Sprite } from "pixi.js";

import { setAnimateMapFireBarrel } from "store/actions/AnimateMap";
import {
Severity: Major
Found in src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts - About 1 day to fix

EntityFactory has 44 functions (exceeds 20 allowed). Consider refactoring.
Open

export default class EntityFactory {
  public engine: Engine;

  constructor(engine: Engine) {
    this.engine = engine;
Severity: Minor
Found in src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts - About 6 hrs to fix

Function createPlayer has 84 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public createPlayer(user: ReplicatedUser): Entity {
    // HACK
    user.data.cycle = avatarCycles[0];

    const movementComponent = new MovementComponent();
Severity: Major
Found in src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts - About 3 hrs to fix

Function enterFirebarrel has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public enterFirebarrel(firebarrelId: string): void {
    console.log("enterFirebarrel");

    const playerNode = this.getPlayerNode();
    const firebarrelNode = this.getFirebarrelNode(firebarrelId);
Severity: Minor
Found in src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts - About 1 hr to fix

Function getRandomBot has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  public getRandomBot(): ReplicatedUser | undefined {
    const bots = GameInstance.instance.getState().users;
    const botIndex = Math.floor(Math.random() * bots.size);
    if (botIndex > 0) {
      const itr = bots.values();
Severity: Minor
Found in src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      new RoundAvatar(url)
        .execute()
        .then((comm: RoundAvatar) => {
          if (!comm.canvas) return Promise.reject();
Severity: Major
Found in src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts and 1 other location - About 4 hrs to fix
src/components/templates/AnimateMap/game/map/entities/createBotEntity.ts on lines 98..113

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 129.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  public updateKeyboard(comm: KeyboardComponent) {
    const nodelist = this.engine.getNodeList(KeyboardNode);
    if (!nodelist.head) {
      return;
    }
Severity: Major
Found in src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts and 2 other locations - About 2 hrs to fix
src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts on lines 187..193
src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts on lines 206..212

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  public updateViewport(comm?: ViewportComponent) {
    const nodelist = this.engine.getNodeList(ViewportNode);
    if (!nodelist.head) {
      return;
    }
Severity: Major
Found in src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts and 2 other locations - About 2 hrs to fix
src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts on lines 206..212
src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts on lines 228..234

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  public updateJoystick(comm?: JoystickComponent) {
    const nodelist = this.engine.getNodeList(JoystickNode);
    if (!nodelist.head) {
      return;
    }
Severity: Major
Found in src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts and 2 other locations - About 2 hrs to fix
src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts on lines 187..193
src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts on lines 228..234

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 81.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    fsm
      .createState(player.WALKING)
      .add(CollisionComponent)
      .withInstance(collision)
      .add(MovementComponent)
Severity: Major
Found in src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts and 2 other locations - About 1 hr to fix
src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts on lines 285..292
src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts on lines 294..301

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    fsm
      .createState(player.FLYING)
      .add(CollisionComponent)
      .withInstance(collision)
      .add(MovementComponent)
Severity: Major
Found in src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts and 2 other locations - About 1 hr to fix
src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts on lines 294..301
src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts on lines 303..310

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    fsm
      .createState(player.CYCLING)
      .add(CollisionComponent)
      .withInstance(collision)
      .add(MovementComponent)
Severity: Major
Found in src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts and 2 other locations - About 1 hr to fix
src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts on lines 285..292
src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts on lines 303..310

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    for (let node = nodes.head; node; node = node.next) {
      if (node.artcar.artcar.data.id === id) {
        return node;
      }
    }
Severity: Major
Found in src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts and 1 other location - About 1 hr to fix
src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts on lines 598..602

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    for (let node = nodes.head; node; node = node.next) {
      if (node.firebarrel.model.data.id === id) {
        return node;
      }
    }
Severity: Major
Found in src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts and 1 other location - About 1 hr to fix
src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts on lines 379..383

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  public getRandomNumber(min: number, max: number): number {
    return Math.floor(Math.random() * (max - min) + min);
  }
Severity: Minor
Found in src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts and 1 other location - About 50 mins to fix
src/components/templates/AnimateMap/game/utils/PlaygroundMap.ts on lines 157..159

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      const x3 =
        r * x2 + (1 - r) * x1 ||
        firebarrelNode.position.x + firebarrelNode.collision.radius * 0.8;
Severity: Minor
Found in src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts and 1 other location - About 50 mins to fix
src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts on lines 501..503

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      const y3 =
        r * y2 + (1 - r) * y1 ||
        firebarrelNode.position.y + firebarrelNode.collision.radius * 0.8;
Severity: Minor
Found in src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts and 1 other location - About 50 mins to fix
src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts on lines 498..500

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      new LoadImage(url)
        .execute()
        .then((comm) => {
          if (comm.image) {
            return new ImageToCanvas(comm.image).execute();
Severity: Minor
Found in src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts and 1 other location - About 30 mins to fix
src/components/templates/AnimateMap/game/map/entities/EntityFactory.ts on lines 350..367

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status