Sign upLogin

sparkletown/sparkle

View on GitHub
Star
src/components/templates/AnimateMap/game/map/entities/createFirebarrelEntity.ts

Summary

Maintainability
C
1 day
Test Coverage

Function createFirebarrelEntity has 102 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const createFirebarrelEntity = (
  barrel: ReplicatedFirebarrel,
  creator: EntityFactory
): Entity => {
  const engine = creator.engine;
Severity: Major
Found in src/components/templates/AnimateMap/game/map/entities/createFirebarrelEntity.ts - About 4 hrs to fix

Function updateBarrelImage has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const updateBarrelImage = (
  barrel: ReplicatedFirebarrel,
  spriteComponent: SpriteComponent,
  positionComponent: PositionComponent
): Promise<void> => {
Severity: Minor
Found in src/components/templates/AnimateMap/game/map/entities/createFirebarrelEntity.ts - About 1 hr to fix

Similar blocks of code found in 4 locations. Consider refactoring.
Open

          if (comm) {
            if (hoverEffectEntity) {
              engine.removeEntity(hoverEffectEntity);
            }
            hoverEffectEntity = new Entity();
Severity: Major
Found in src/components/templates/AnimateMap/game/map/entities/createFirebarrelEntity.ts and 3 other locations - About 2 hrs to fix
src/components/templates/AnimateMap/game/map/entities/createFirebarrelEntity.ts on lines 178..190
src/components/templates/AnimateMap/game/map/entities/createVenueEntity.ts on lines 185..197
src/components/templates/AnimateMap/game/map/entities/createVenueEntity.ts on lines 204..216

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 77.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

          if (comm) {
            if (hoverEffectEntity) {
              engine.removeEntity(hoverEffectEntity);
            }
            hoverEffectEntity = new Entity();
Severity: Major
Found in src/components/templates/AnimateMap/game/map/entities/createFirebarrelEntity.ts and 3 other locations - About 2 hrs to fix
src/components/templates/AnimateMap/game/map/entities/createFirebarrelEntity.ts on lines 197..209
src/components/templates/AnimateMap/game/map/entities/createVenueEntity.ts on lines 185..197
src/components/templates/AnimateMap/game/map/entities/createVenueEntity.ts on lines 204..216

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 77.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  fsm
    .createState(barrelComponent.HALO_ANIMATED)
    .add(AnimationComponent)
    .withMethod(
      (): AnimationComponent => {
Severity: Major
Found in src/components/templates/AnimateMap/game/map/entities/createFirebarrelEntity.ts and 1 other location - About 1 hr to fix
src/components/templates/AnimateMap/game/map/entities/createVenueEntity.ts on lines 149..159

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  updateBarrelImage(barrel, spriteComponent, positionComponent).finally(() => {
    if (spriteComponent && spriteComponent.view) {
      spriteComponent.view.visible = true;
    }
  });
Severity: Minor
Found in src/components/templates/AnimateMap/game/map/entities/createFirebarrelEntity.ts and 1 other location - About 50 mins to fix
src/components/templates/AnimateMap/game/map/entities/createVenueEntity.ts on lines 240..244

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  fsm
    .createState(barrelComponent.HALO)
    .add(FirebarrelHalo)
    .withMethod(
      (): FirebarrelHalo => {
Severity: Major
Found in src/components/templates/AnimateMap/game/map/entities/createFirebarrelEntity.ts and 3 other locations - About 40 mins to fix
src/components/templates/AnimateMap/game/map/entities/createFirebarrelEntity.ts on lines 132..139
src/components/templates/AnimateMap/game/map/entities/createVenueEntity.ts on lines 131..138
src/components/templates/AnimateMap/game/map/entities/createVenueEntity.ts on lines 140..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  fsm
    .createState(barrelComponent.WITHOUT_HALO)
    .add(FirebarrelHaloEmpty)
    .withMethod(
      (): FirebarrelHaloEmpty => {
Severity: Major
Found in src/components/templates/AnimateMap/game/map/entities/createFirebarrelEntity.ts and 3 other locations - About 40 mins to fix
src/components/templates/AnimateMap/game/map/entities/createFirebarrelEntity.ts on lines 140..147
src/components/templates/AnimateMap/game/map/entities/createVenueEntity.ts on lines 131..138
src/components/templates/AnimateMap/game/map/entities/createVenueEntity.ts on lines 140..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status