Sign upLogin

sparkletown/sparkle

View on GitHub
Star
src/pages/Account/Venue/VenueMapEdition/Container.tsx

Summary

Maintainability
F
3 days
Test Coverage

Function Container has 220 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const Container: React.FC<PropsType> = (props) => {
  const {
    snapToGrid,
    iconsMap,
    backgroundImage,
Severity: Major
Found in src/pages/Account/Venue/VenueMapEdition/Container.tsx - About 1 day to fix

File Container.tsx has 279 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React, {
  CSSProperties,
  useCallback,
  useEffect,
  useMemo,
Severity: Minor
Found in src/pages/Account/Venue/VenueMapEdition/Container.tsx - About 2 hrs to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const [, drop] = useDrop({
    accept: ItemTypes.SUBVENUE_ICON,
    drop: (item: DragItem, monitor) => {
      if (!interactive) return;
      const delta = monitor.getDifferenceFromInitialOffset() as {
Severity: Major
Found in src/pages/Account/Venue/VenueMapEdition/Container.tsx and 1 other location - About 6 hrs to fix
src/components/organisms/AdminVenueView/components/VenueRoomsEditor/VenueRoomsEditor.tsx on lines 214..231

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 170.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      (acc, val) => ({
        ...acc,
        [val]: {
          ...iconsMap[val],
          width: resizable
Severity: Major
Found in src/pages/Account/Venue/VenueMapEdition/Container.tsx and 1 other location - About 6 hrs to fix
src/components/organisms/AdminVenueView/components/VenueRoomsEditor/VenueRoomsEditor.tsx on lines 117..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 162.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const {
    snapToGrid,
    iconsMap,
    backgroundImage,
    iconImageStyle,
Severity: Major
Found in src/pages/Account/Venue/VenueMapEdition/Container.tsx and 1 other location - About 2 hrs to fix
src/components/organisms/AdminVenueView/components/VenueRoomsEditor/VenueRoomsEditor.tsx on lines 75..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      {imageDims && interactive && (
        <CustomDragLayer
          snapToGrid={!!snapToGrid}
          rounded={!!rounded}
          iconSize={boxes[Object.keys(boxes)[dragBoxId]]}
Severity: Major
Found in src/pages/Account/Venue/VenueMapEdition/Container.tsx and 1 other location - About 1 hr to fix
src/components/organisms/AdminVenueView/components/VenueRoomsEditor/VenueRoomsEditor.tsx on lines 246..252

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status