Sign upLogin

spheromak/services

View on GitHub
Star

Showing 3 of 3 total issues

Method _load has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def _load
      return unless valid_path
      to_hash.each do |k, _v|
        next if k == 'name'
        next unless Services.exists? "#{KEY}/#{path}/#{k}"
Severity: Minor
Found in lib/services/entity.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method subscribed has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def subscribed(f = nil)
      fail 'param and run_context can not both be nil' if f.nil? && run_context.nil?
      fqdn = f.nil? ? run_context.node.fqdn : f
      services = []
      all.each do |s|
Severity: Minor
Found in lib/services.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_connection has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def get_connection(servers = nil)
      c = nil
      if servers
        servers.each do |s|
          c = try_connect(s)
Severity: Minor
Found in lib/services/connection.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language