Sign upLogin

spicycms/spicy.core

View on GitHub
Star
src/spicy/core/siteskin/widgets.py

Summary

Maintainability
F
3 days
Test Coverage

File widgets.py has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from django.conf import settings

from django.db.models import ObjectDoesNotExist

from django import forms
Severity: Minor
Found in src/spicy/core/siteskin/widgets.py - About 2 hrs to fix

    Function __init__ has 15 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, queryset, callback, options={}, attrs={},
    Severity: Major
    Found in src/spicy/core/siteskin/widgets.py - About 1 hr to fix

      Function render_options has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def render_options(self, choices, selected_choice, field_id, name):
        if isinstance(self.callback, list):
            callback = JSONEncoder().encode(self.callback)
        elif isinstance(self.callback, basestring):
            try:
      Severity: Minor
      Found in src/spicy/core/siteskin/widgets.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, callback, options={}, attrs={},
      Severity: Minor
      Found in src/spicy/core/siteskin/widgets.py - About 45 mins to fix

        Function render_options has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def render_options(self, choices, selected_choice, field_id, name):
        Severity: Minor
        Found in src/spicy/core/siteskin/widgets.py - About 35 mins to fix

          Function render has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def render(self, name, value, attrs=None, choices=()):
          Severity: Minor
          Found in src/spicy/core/siteskin/widgets.py - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            class DateTimePicker(forms.TextInput):
    def __init__(self, options={}, attrs={}):
        self.options = JSONEncoder().encode(options)
        self.attrs = attrs
            Severity: Major
            Found in src/spicy/core/siteskin/widgets.py and 1 other location - About 1 day to fix
            src/spicy/core/siteskin/widgets.py on lines 292..304

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 125.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            class DatePicker(forms.TextInput):
    def __init__(self, options={}, attrs={}):
        self.options = JSONEncoder().encode(options)
        self.attrs = attrs
            Severity: Major
            Found in src/spicy/core/siteskin/widgets.py and 1 other location - About 1 day to fix
            src/spicy/core/siteskin/widgets.py on lines 306..318

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 125.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

            class LabledEmailField(BaseLabledField, forms.EmailField):
    widget = LabledTextInput

    def __init__(self, *args, **kwargs):
        super(LabledEmailField, self).__init__(*args, **kwargs)
            Severity: Major
            Found in src/spicy/core/siteskin/widgets.py and 3 other locations - About 1 hr to fix
            src/spicy/core/siteskin/widgets.py on lines 66..71
            src/spicy/core/siteskin/widgets.py on lines 74..79
            src/spicy/core/siteskin/widgets.py on lines 82..87

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

            class LabledCharField(BaseLabledField, forms.CharField):
    widget = LabledTextInput

    def __init__(self, *args, **kwargs):
        super(LabledCharField, self).__init__(*args, **kwargs)
            Severity: Major
            Found in src/spicy/core/siteskin/widgets.py and 3 other locations - About 1 hr to fix
            src/spicy/core/siteskin/widgets.py on lines 74..79
            src/spicy/core/siteskin/widgets.py on lines 82..87
            src/spicy/core/siteskin/widgets.py on lines 90..95

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

            class LabledRegexField(BaseLabledField, forms.RegexField):
    widget = LabledTextInput

    def __init__(self, *args, **kwargs):
        super(LabledRegexField, self).__init__(*args, **kwargs)
            Severity: Major
            Found in src/spicy/core/siteskin/widgets.py and 3 other locations - About 1 hr to fix
            src/spicy/core/siteskin/widgets.py on lines 66..71
            src/spicy/core/siteskin/widgets.py on lines 74..79
            src/spicy/core/siteskin/widgets.py on lines 90..95

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

            class LabledTextField(BaseLabledField, forms.CharField):
    widget = LabledTextarea

    def __init__(self, *args, **kwargs):
        super(LabledTextField, self).__init__(*args, **kwargs)
            Severity: Major
            Found in src/spicy/core/siteskin/widgets.py and 3 other locations - About 1 hr to fix
            src/spicy/core/siteskin/widgets.py on lines 66..71
            src/spicy/core/siteskin/widgets.py on lines 82..87
            src/spicy/core/siteskin/widgets.py on lines 90..95

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status