spiritix/lada-cache

View on GitHub
src/Spiritix/LadaCache/Database/LadaCacheTrait.php

Summary

Maintainability
A
35 mins
Test Coverage
C
72%

Method newPivot has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function newPivot(Model $parent, array $attributes, $table, $exists, $using = null)
Severity: Minor
Found in src/Spiritix/LadaCache/Database/LadaCacheTrait.php - About 35 mins to fix

    Avoid using static access to class 'Spiritix\LadaCache\Database\Pivot' in method 'newPivot'.
    Open

                : Pivot::fromAttributes($parent, $attributes, $table, $exists);

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    There are no issues that match your filters.

    Category
    Status