Sign upLogin

spiritix/lada-cache

View on GitHub
Star
src/Spiritix/LadaCache/Database/QueryBuilder.php

Summary

Maintainability
A
35 mins
Test Coverage
B
82%

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        ConnectionInterface $connection,
        Grammar $grammar = null,
        Processor $processor = null,
        QueryHandler $handler,
        Model $model = null
Severity: Minor
Found in src/Spiritix/LadaCache/Database/QueryBuilder.php - About 35 mins to fix

    Avoid variables with short names like $id. Configured minimum length is 3.
    Open

        public function delete($id = null)
    Severity: Minor
    Found in src/Spiritix/LadaCache/Database/QueryBuilder.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $as. Configured minimum length is 3.
    Open

        public function selectSub($query, $as)
    Severity: Minor
    Found in src/Spiritix/LadaCache/Database/QueryBuilder.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Expected 1 space after FUNCTION keyword; 0 found
    Open

            return $this->handler->setBuilder($this)->cacheQuery(function() {
    Severity: Minor
    Found in src/Spiritix/LadaCache/Database/QueryBuilder.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status