spiritix/lada-cache

View on GitHub
src/Spiritix/LadaCache/Reflector.php

Summary

Maintainability
B
6 hrs
Test Coverage
A
94%

Function getRows has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public function getRows()
    {
        $rows = [];
        $wheres = $this->queryBuilder->wheres ?: [];

Severity: Minor
Found in src/Spiritix/LadaCache/Reflector.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getTablesFromWhere has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    private function getTablesFromWhere(QueryBuilder $queryBuilder, &$tables) {
        if (!isset($queryBuilder->wheres)) {
            return;
        }
        $wheres = $queryBuilder->wheres ?: [];
Severity: Minor
Found in src/Spiritix/LadaCache/Reflector.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getCompileFunction has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private function getCompileFunction()
    {
        switch (strtolower($this->sqlOperation)) {
            case self::QUERY_TYPE_INSERT:
                return 'compileInsert';
Severity: Minor
Found in src/Spiritix/LadaCache/Reflector.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

                return 'compileTruncate';
Severity: Major
Found in src/Spiritix/LadaCache/Reflector.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return 'compileSelect';
    Severity: Major
    Found in src/Spiritix/LadaCache/Reflector.php - About 30 mins to fix

      The method getTablesFromWhere() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
      Open

          private function getTablesFromWhere(QueryBuilder $queryBuilder, &$tables) {
              if (!isset($queryBuilder->wheres)) {
                  return;
              }
              $wheres = $queryBuilder->wheres ?: [];
      Severity: Minor
      Found in src/Spiritix/LadaCache/Reflector.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      The method getRows() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
      Open

          public function getRows()
          {
              $rows = [];
              $wheres = $this->queryBuilder->wheres ?: [];
      
      
      Severity: Minor
      Found in src/Spiritix/LadaCache/Reflector.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      The method splitTableAndColumn uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
                  $table = $parts[0];
              }
      Severity: Minor
      Found in src/Spiritix/LadaCache/Reflector.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Blank line found at start of control structure
      Open

                      foreach ($joins as $join) {

      Blank line found at start of control structure
      Open

              foreach ($wheres as $where) {

      Blank line found at start of control structure
      Open

              foreach ($joins as $join) {

      Usage of ELSE IF is discouraged; use ELSEIF instead
      Open

                  } else if ($where['type'] === 'In') {

      Opening brace should be on a new line
      Open

          private function getTablesFromWhere(QueryBuilder $queryBuilder, &$tables) {

      There are no issues that match your filters.

      Category
      Status