Showing 22 of 22 total issues
TRUE, FALSE and NULL must be lowercase; expected "false" but found "FALSE" Open
if (filter_var($url, FILTER_VALIDATE_URL) === FALSE) {- Exclude checks
The method embed has a boolean flag argument $exit, which is a certain sign of a Single Responsibility Principle violation. Open
public function embed(string $fileName, bool $exit = true)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The method download has a boolean flag argument $exit, which is a certain sign of a Single Responsibility Principle violation. Open
public function download(string $fileName, bool $exit = true)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The method download() contains an exit expression. Open
exit;- Read upRead up
- Exclude checks
ExitExpression
Since: 0.2
An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.
Example
class Foo {
public function bar($param) {
if ($param === 42) {
exit(23);
}
}
}Source https://phpmd.org/rules/design.html#exitexpression
The method embed() contains an exit expression. Open
exit;- Read upRead up
- Exclude checks
ExitExpression
Since: 0.2
An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.
Example
class Foo {
public function bar($param) {
if ($param === 42) {
exit(23);
}
}
}Source https://phpmd.org/rules/design.html#exitexpression
The method escapeShellArgument uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
else {
return self::escapeShellArgumentLinux($argument);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'Spiritix\Html2Pdf\ProcessUtil' in method 'convert'. Open
$result = ProcessUtil::executeShellCommand($this->buildCommand(), $this->input->getHtml());- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid using static access to class 'Spiritix\Html2Pdf\ProcessUtil' in method 'buildCommand'. Open
$options = ProcessUtil::escapeShellArgument(json_encode($this->getOptions(), JSON_UNESCAPED_SLASHES));- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Expected 1 newline at end of file; 0 found Open
}- Exclude checks
Expected 1 newline at end of file; 0 found Open
}- Exclude checks
Expected 1 newline at end of file; 0 found Open
}- Exclude checks
Expected 1 newline at end of file; 0 found Open
}- Exclude checks
Expected 1 newline at end of file; 0 found Open
}- Exclude checks
Expected 1 newline at end of file; 0 found Open
}- Exclude checks
Expected 1 space after closing brace; newline found Open
}- Exclude checks
Expected 1 newline at end of file; 0 found Open
}- Exclude checks
Expected 1 newline at end of file; 0 found Open
}- Exclude checks
Expected 1 newline at end of file; 0 found Open
}- Exclude checks
Expected 1 newline at end of file; 0 found Open
}- Exclude checks
Expected 1 newline at end of file; 0 found Open
}- Exclude checks