Sign upLogin

sporkmonger/ecsevent

View on GitHub
Star

Showing 8 of 8 total issues

Function NewHandler has a Cognitive Complexity of 60 (exceeds 20 allowed). Consider refactoring.
Open

func NewHandler(monitor ecsevent.Monitor) func(http.Handler) http.Handler {
    if monitor == nil {
        monitor = &ecsevent.NopMonitor{}
    } else if _, ok := monitor.(*ecsevent.SpanMonitor); ok {
        monitor.Record(map[string]interface{}{
Severity: Minor
Found in httpmw/middleware.go - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function NewHandler has 120 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func NewHandler(monitor ecsevent.Monitor) func(http.Handler) http.Handler {
    if monitor == nil {
        monitor = &ecsevent.NopMonitor{}
    } else if _, ok := monitor.(*ecsevent.SpanMonitor); ok {
        monitor.Record(map[string]interface{}{
Severity: Major
Found in httpmw/middleware.go - About 3 hrs to fix

    File ecs.go has 514 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    package ecsevent

import (
    "fmt"
    "reflect"
    Severity: Minor
    Found in ecs.go - About 2 hrs to fix

      Function stackdriverSeverity has 80 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func stackdriverSeverity(level string) string {
    // ECS doesn't specify accepted values for log.level
    switch strings.ToLower(level) {
    case "t":
        fallthrough
      Severity: Major
      Found in stackdriver.go - About 2 hrs to fix

        Function stackdriverSeverity has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
        Open

        func stackdriverSeverity(level string) string {
    // ECS doesn't specify accepted values for log.level
    switch strings.ToLower(level) {
    case "t":
        fallthrough
        Severity: Minor
        Found in stackdriver.go - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method Emitter.Emit has 53 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (e *Emitter) Emit(event map[string]interface{}) {
    // TODO: maybe a constructor?
    // Quick and dirty for now.
    if e.client == nil {
        e.client = &http.Client{
        Severity: Minor
        Found in humio/emitter.go - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (rm *RootMonitor) UpdateFields(fields map[string]interface{}) {
    rm.mu.Lock()
    defer rm.mu.Unlock()
    if rm.fields == nil {
        rm.fields = make(map[string]interface{})
          Severity: Minor
          Found in monitor.go and 1 other location - About 50 mins to fix
          span_monitor.go on lines 102..111

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (sm *SpanMonitor) UpdateFields(fields map[string]interface{}) {
    sm.mu.Lock()
    defer sm.mu.Unlock()
    if sm.fields == nil {
        sm.fields = make(map[string]interface{})
          Severity: Minor
          Found in span_monitor.go and 1 other location - About 50 mins to fix
          monitor.go on lines 151..160

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language