Sign upLogin

sporkmonger/ecsevent

View on GitHub
Star

Showing 6 of 8 total issues

Function NewHandler has a Cognitive Complexity of 60 (exceeds 20 allowed). Consider refactoring.
Open

func NewHandler(monitor ecsevent.Monitor) func(http.Handler) http.Handler {
    if monitor == nil {
        monitor = &ecsevent.NopMonitor{}
    } else if _, ok := monitor.(*ecsevent.SpanMonitor); ok {
        monitor.Record(map[string]interface{}{
Severity: Minor
Found in httpmw/middleware.go - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function NewHandler has 120 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func NewHandler(monitor ecsevent.Monitor) func(http.Handler) http.Handler {
    if monitor == nil {
        monitor = &ecsevent.NopMonitor{}
    } else if _, ok := monitor.(*ecsevent.SpanMonitor); ok {
        monitor.Record(map[string]interface{}{
Severity: Major
Found in httpmw/middleware.go - About 3 hrs to fix

    File ecs.go has 514 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    package ecsevent

import (
    "fmt"
    "reflect"
    Severity: Minor
    Found in ecs.go - About 2 hrs to fix

      Function stackdriverSeverity has 80 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func stackdriverSeverity(level string) string {
    // ECS doesn't specify accepted values for log.level
    switch strings.ToLower(level) {
    case "t":
        fallthrough
      Severity: Major
      Found in stackdriver.go - About 2 hrs to fix

        Function stackdriverSeverity has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
        Open

        func stackdriverSeverity(level string) string {
    // ECS doesn't specify accepted values for log.level
    switch strings.ToLower(level) {
    case "t":
        fallthrough
        Severity: Minor
        Found in stackdriver.go - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method Emitter.Emit has 53 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (e *Emitter) Emit(event map[string]interface{}) {
    // TODO: maybe a constructor?
    // Quick and dirty for now.
    if e.client == nil {
        e.client = &http.Client{
        Severity: Minor
        Found in humio/emitter.go - About 1 hr to fix
          Severity
          Category
          Status
          Source
          Language