Sign upLogin

spotweb/spotweb

View on GitHub
Star
lib/dbstruct/SpotStruct_pgsql.php

Summary

Maintainability
F
4 days
Test Coverage

File SpotStruct_pgsql.php has 410 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

class SpotStruct_pgsql extends SpotStruct_abs
{
    /*
Severity: Minor
Found in lib/dbstruct/SpotStruct_pgsql.php - About 5 hrs to fix

    SpotStruct_pgsql has 26 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class SpotStruct_pgsql extends SpotStruct_abs
{
    /*
     * Optimize / analyze (database specific) a number of hightraffic
     * tables.
    Severity: Minor
    Found in lib/dbstruct/SpotStruct_pgsql.php - About 3 hrs to fix

      Function modifyColumn has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function modifyColumn($colName, $tablename, $colType, $colDefault, $notNull, $collation, $what)
    {
        // check if $colDefault is not null as strlen does not accept null as parameter.
        if (!is_null($colDefault)) {
            // set the DEFAULT value
      Severity: Minor
      Found in lib/dbstruct/SpotStruct_pgsql.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getColumnInfo has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getColumnInfo($tablename, $colname)
    {
        $q = $this->_dbcon->arrayQuery(
            "SELECT column_name AS \"COLUMN_NAME\",
                                               column_default AS \"COLUMN_DEFAULT\",
      Severity: Minor
      Found in lib/dbstruct/SpotStruct_pgsql.php - About 1 hr to fix

        Method getIndexInfo has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getIndexInfo($idxname, $tablename)
    {
        $q = $this->_dbcon->arrayQuery(
            'SELECT * 
                                        FROM pg_indexes
        Severity: Minor
        Found in lib/dbstruct/SpotStruct_pgsql.php - About 1 hr to fix

          Method modifyColumn has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function modifyColumn($colName, $tablename, $colType, $colDefault, $notNull, $collation, $what)
    {
        // check if $colDefault is not null as strlen does not accept null as parameter.
        if (!is_null($colDefault)) {
            // set the DEFAULT value
          Severity: Minor
          Found in lib/dbstruct/SpotStruct_pgsql.php - About 1 hr to fix

            Method dropForeignKey has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function dropForeignKey($tablename, $colname, $reftable, $refcolumn, $action)
    {
        /* SQL from http://stackoverflow.com/questions/1152260/postgres-sql-to-list-table-foreign-keys */
        $q = $this->_dbcon->arrayQuery(
            "SELECT
            Severity: Minor
            Found in lib/dbstruct/SpotStruct_pgsql.php - About 1 hr to fix

              Method addForeignKey has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function addForeignKey($tablename, $colname, $reftable, $refcolumn, $action)
    {
        /* SQL from http://stackoverflow.com/questions/1152260/postgres-sql-to-list-table-foreign-keys */
        $q = $this->_dbcon->arrayQuery(
            "SELECT
              Severity: Minor
              Found in lib/dbstruct/SpotStruct_pgsql.php - About 1 hr to fix

                Function getColumnInfo has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getColumnInfo($tablename, $colname)
    {
        $q = $this->_dbcon->arrayQuery(
            "SELECT column_name AS \"COLUMN_NAME\",
                                               column_default AS \"COLUMN_DEFAULT\",
                Severity: Minor
                Found in lib/dbstruct/SpotStruct_pgsql.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method modifyColumn has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function modifyColumn($colName, $tablename, $colType, $colDefault, $notNull, $collation, $what)
                Severity: Major
                Found in lib/dbstruct/SpotStruct_pgsql.php - About 50 mins to fix

                  Method addColumn has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function addColumn($colName, $tablename, $colType, $colDefault, $notNull, $collation)
                  Severity: Minor
                  Found in lib/dbstruct/SpotStruct_pgsql.php - About 45 mins to fix

                    Method dropForeignKey has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function dropForeignKey($tablename, $colname, $reftable, $refcolumn, $action)
                    Severity: Minor
                    Found in lib/dbstruct/SpotStruct_pgsql.php - About 35 mins to fix

                      Method addForeignKey has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public function addForeignKey($tablename, $colname, $reftable, $refcolumn, $action)
                      Severity: Minor
                      Found in lib/dbstruct/SpotStruct_pgsql.php - About 35 mins to fix

                        Function addColumn has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function addColumn($colName, $tablename, $colType, $colDefault, $notNull, $collation)
    {
        if (!$this->columnExists($tablename, $colName)) {
            // set the DEFAULT value
            if (strlen($colDefault) != 0) {
                        Severity: Minor
                        Found in lib/dbstruct/SpotStruct_pgsql.php - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function swDtToNative has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function swDtToNative($colType)
    {
        switch (strtoupper($colType)) {
            case 'INTEGER': $colType = 'integer';
                break;
                        Severity: Minor
                        Found in lib/dbstruct/SpotStruct_pgsql.php - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                            public function analyze()
    {
        $this->_dbcon->rawExec('VACUUM ANALYZE spots');
        $this->_dbcon->rawExec('VACUUM ANALYZE spotsfull');
        $this->_dbcon->rawExec('VACUUM ANALYZE commentsxover');
                        Severity: Major
                        Found in lib/dbstruct/SpotStruct_pgsql.php and 3 other locations - About 3 hrs to fix
                        lib/dbstruct/SpotStruct_mysql.php on lines 10..25
                        lib/dbstruct/SpotStruct_pgsql.php on lines 29..44
                        lib/dbstruct/SpotStruct_sqlite.php on lines 10..25

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 147.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 4 locations. Consider refactoring.
                        Open

                            public function resetdb()
    {
        $this->_dbcon->rawExec('TRUNCATE TABLE spotsposted CASCADE');
        $this->_dbcon->rawExec('TRUNCATE TABLE spotsfull CASCADE');
        $this->_dbcon->rawExec('TRUNCATE TABLE spotstatelist CASCADE');
                        Severity: Major
                        Found in lib/dbstruct/SpotStruct_pgsql.php and 3 other locations - About 3 hrs to fix
                        lib/dbstruct/SpotStruct_mysql.php on lines 10..25
                        lib/dbstruct/SpotStruct_pgsql.php on lines 10..25
                        lib/dbstruct/SpotStruct_sqlite.php on lines 10..25

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 147.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            public function createFts($ftsname, $tablename, $colList)
    {
        foreach ($colList as $num => $col) {
            $indexInfo = $this->getIndexInfo($ftsname.'_'.$num, $tablename);
                        Severity: Major
                        Found in lib/dbstruct/SpotStruct_pgsql.php and 1 other location - About 2 hrs to fix
                        lib/dbstruct/SpotStruct_mysql.php on lines 186..196

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 137.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            public function ftsExists($ftsname, $tablename, $colList)
    {
        foreach ($colList as $num => $col) {
            $indexInfo = $this->getIndexInfo($ftsname.'_'.$num, $tablename);
                        Severity: Minor
                        Found in lib/dbstruct/SpotStruct_pgsql.php and 1 other location - About 55 mins to fix
                        lib/dbstruct/SpotStruct_mysql.php on lines 170..181

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 98.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                            public function swDtToNative($colType)
    {
        switch (strtoupper($colType)) {
            case 'INTEGER': $colType = 'integer';
                break;
                        Severity: Major
                        Found in lib/dbstruct/SpotStruct_pgsql.php and 2 other locations - About 40 mins to fix
                        lib/dbstruct/SpotStruct_mysql.php on lines 74..92
                        lib/dbstruct/SpotStruct_sqlite.php on lines 77..95

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 94.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status