Sign upLogin

spree/spree

View on GitHub
Star
api/app/models/concerns/spree/webhooks/has_webhooks.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method queue_webhooks_requests! has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

        def queue_webhooks_requests!(event_name)
          return if disable_spree_webhooks?
          return if Spree::Webhooks::Subscriber.none?
          return if Spree::Webhooks::Subscriber.active.with_urls_for(event_name).none?
          return if update_event?(event_name) && updating_only_ignored_attributes?
Severity: Minor
Found in api/app/models/concerns/spree/webhooks/has_webhooks.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

          return if webhook_payload_body.blank?
Severity: Major
Found in api/app/models/concerns/spree/webhooks/has_webhooks.rb - About 30 mins to fix

    There are no issues that match your filters.

    Category
    Status