Sign upLogin

spree/spree

View on GitHub
Star
core/app/finders/spree/products/find.rb

Summary

Maintainability
B
6 hrs
Test Coverage
A
96%

Class Find has 33 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Find
      def initialize(scope:, params:, current_currency: nil)
        @scope = scope

        if current_currency.present?
Severity: Minor
Found in core/app/finders/spree/products/find.rb - About 4 hrs to fix

    Method by_properties has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

          def by_properties(products)
        return products unless properties?

        product_ids = []
        index = 0
    Severity: Minor
    Found in core/app/finders/spree/products/find.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method ordered has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def ordered(products)
        return products unless sort_by?

        case sort_by
        when 'default'
    Severity: Minor
    Found in core/app/finders/spree/products/find.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status