Sign upLogin

spree/spree

View on GitHub
Star
core/app/models/spree/zone.rb

Summary

Maintainability
B
4 hrs
Test Coverage
B
83%

Class Zone has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Zone < Spree::Base
    include Spree::UniqueName
    if defined?(Spree::Webhooks::HasWebhooks)
      include Spree::Webhooks::HasWebhooks
    end
Severity: Minor
Found in core/app/models/spree/zone.rb - About 2 hrs to fix

    Method contains? has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        def contains?(target)
      return false if state? && target.country?
      return false if zone_members.empty? || target.zone_members.empty?

      if kind == target.kind
    Severity: Minor
    Found in core/app/models/spree/zone.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return false if (target.states.pluck(:country_id) - countries.pluck(:id)).present?
    Severity: Major
    Found in core/app/models/spree/zone.rb - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status