Sign upLogin

spree/spree

View on GitHub
Star
core/lib/spree/core/preferences/preferable.rb

Summary

Maintainability
B
4 hrs
Test Coverage
A
96%

Method convert_preference_value has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  def convert_preference_value(value, type)
    case type
    when :string, :text
      value.to_s
    when :password
Severity: Minor
Found in core/lib/spree/core/preferences/preferable.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method convert_preference_value has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def convert_preference_value(value, type)
    case type
    when :string, :text
      value.to_s
    when :password
Severity: Minor
Found in core/lib/spree/core/preferences/preferable.rb - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

          if value.is_a?(FalseClass) ||
          value.nil? ||
          value == 0 ||
          value&.to_s =~ /^(f|false|0)$/i ||
          (value.respond_to?(:empty?) && value.empty?)
    Severity: Major
    Found in core/lib/spree/core/preferences/preferable.rb - About 40 mins to fix

      There are no issues that match your filters.

      Category
      Status