Sign upLogin

springernature/macmillan-utils

View on GitHub
Star

Showing 5 of 5 total issues

Method convert_keys_to_snakecase_and_symbols has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def convert_keys_to_snakecase_and_symbols(obj)
          case obj
          when Array
            obj.reduce([]) do |res, val|
              res << case val
Severity: Minor
Found in lib/macmillan/utils/helper/hash_key_helper.rb - About 1 hr to fix

    Method convert_keys_to_snakecase_and_symbols has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

            def convert_keys_to_snakecase_and_symbols(obj)
          case obj
          when Array
            obj.reduce([]) do |res, val|
              res << case val
    Severity: Minor
    Found in lib/macmillan/utils/helper/hash_key_helper.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

              def initialize(env, app, user_env_key, user_id_method, cookie_key)
    Severity: Minor
    Found in lib/macmillan/utils/middleware/uuid.rb - About 35 mins to fix

      Method application_yml_path has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

              def application_yml_path
          search_pattern  = File.join('config', 'application.yml')
          here            = File.expand_path(Dir.pwd)
          path_components = here.split(/\//)
          found_path      = nil
      Severity: Minor
      Found in lib/macmillan/utils/settings/app_yaml_backend.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method cookies_accepted? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

              def cookies_accepted?(request)
          debug("request.post? IS #{request.post?.inspect}")
          debug("request.cookies[#{COOKIE}] IS #{request.cookies[COOKIE].inspect}")
          debug("request.params['cookies'] IS #{request.params['cookies'].inspect}")
          debug("request.cookies IS #{request.cookies.inspect}")
      Severity: Minor
      Found in lib/macmillan/utils/middleware/cookie_message.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language