Sign upLogin

springload/workshops

View on GitHub
Star

Showing 36 of 36 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

export const ProductCategoryRow = React.createClass({
    render() {
        return (
            <tr>
                <th colSpan={2}>{this.props.category}</th>
Severity: Major
Found in thinking-in-react/solution4.js and 3 other locations - About 1 hr to fix
thinking-in-react/solution3.js on lines 3..11
thinking-in-react/solution5.js on lines 4..12
thinking-in-react/solution6.js on lines 5..13

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

export const ProductCategoryRow = React.createClass({
    render() {
        return (
            <tr>
                <th colSpan={2}>{this.props.category}</th>
Severity: Major
Found in thinking-in-react/solution6.js and 3 other locations - About 1 hr to fix
thinking-in-react/solution3.js on lines 3..11
thinking-in-react/solution4.js on lines 3..11
thinking-in-react/solution5.js on lines 4..12

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function update_quality has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function update_quality(items) {
    for (var i = 0; i < items.length; i++) {
        if (items[i].name != 'Aged Brie' && items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
            if (items[i].quality > 0) {
                if (items[i].name != 'Sulfuras, Hand of Ragnaros') {
Severity: Minor
Found in writing-good-code/src/gilded_rose.js - About 1 hr to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    export const ProductCategoryRow = React.createClass({
    render() {
        return (
            <tr>
                <th colSpan={2}>{this.props.category}</th>
    Severity: Major
    Found in thinking-in-react/solution3.js and 3 other locations - About 1 hr to fix
    thinking-in-react/solution4.js on lines 3..11
    thinking-in-react/solution5.js on lines 4..12
    thinking-in-react/solution6.js on lines 5..13

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 71.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function render has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render() {
        const { products, filterText, inStockOnly } = this.props;

        const rows = [];
        let currentCategory;
    Severity: Minor
    Found in thinking-in-react/solution4.js - About 1 hr to fix

      Function render has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          render() {
        const { products, filterText, inStockOnly } = this.props;

        const rows = [];
        let currentCategory;
      Severity: Minor
      Found in thinking-in-react/solution6.js - About 1 hr to fix

        Function render has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            render() {
        const { products, filterText, inStockOnly } = this.props;

        const rows = [];
        let currentCategory;
        Severity: Minor
        Found in thinking-in-react/solution5.js - About 1 hr to fix

          Function update has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function update(item) {
    switch (item.name) {
    case 'Backstage passes to a TAFKAL80ETC concert':
        item.quality = change_quality(item.quality, 1);
          Severity: Minor
          Found in writing-good-code/src/gilded_rose_solution.js - About 1 hr to fix

            Function render has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                render() {
        const products = this.props.products;

        const rows = [];
        let currentCategory;
            Severity: Minor
            Found in thinking-in-react/solution3.js - About 1 hr to fix

              Function update has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

              function update(item) {
    switch (item.name) {
    case 'Backstage passes to a TAFKAL80ETC concert':
        item.quality = change_quality(item.quality, 1);
              Severity: Minor
              Found in writing-good-code/src/gilded_rose_solution.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid deeply nested control flow statements.
              Open

                        if (items[i].sell_in < 6) {
            if (items[i].quality < 50) {
              items[i].quality = items[i].quality + 1
            }
          }
              Severity: Major
              Found in tdd-workshop/src/gilded_rose.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                          if (items[i].sell_in < 11) {
            if (items[i].quality < 50) {
              items[i].quality = items[i].quality + 1
            }
          }
                Severity: Major
                Found in tdd-workshop/src/gilded_rose.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                      if (items[i].quality > 0) {
                        if (items[i].name != 'Sulfuras, Hand of Ragnaros') {
                            items[i].quality = items[i].quality - 1
                        }
                    }
                  Severity: Major
                  Found in writing-good-code/src/gilded_rose.js - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                        if (items[i].sell_in < 6) {
                        if (items[i].quality < 50) {
                            items[i].quality = items[i].quality + 1
                        }
                    }
                    Severity: Major
                    Found in writing-good-code/src/gilded_rose.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                          if (items[i].sell_in < 11) {
                        if (items[i].quality < 50) {
                            items[i].quality = items[i].quality + 1
                        }
                    }
                      Severity: Major
                      Found in writing-good-code/src/gilded_rose.js - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                  if (items[i].quality > 0) {
            if (items[i].name != 'Sulfuras, Hand of Ragnaros') {
              items[i].quality = items[i].quality - 1
            }
          }
                        Severity: Major
                        Found in tdd-workshop/src/gilded_rose.js - About 45 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language