sprinkle-tool/sprinkle

View on GitHub
lib/sprinkle/package.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class Package has 30 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Package #:nodoc:
      attr_accessor :name, :provides, :verifications
      attr_internal :args, :opts
      cattr_reader :installer_methods
      @@installer_methods = []
Severity: Minor
Found in lib/sprinkle/package.rb - About 3 hrs to fix

    Method tree_for_packages has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def tree_for_packages(packages, opts={}, &block)
            depth = opts[:depth]
            tree = []
            packages.each do |dep, config|
              package = PACKAGES.find_all(dep, config)
    Severity: Minor
    Found in lib/sprinkle/package.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method process has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def process(deployment, roles)
            output_name
            return if meta_package?
    
            # Run a pre-test to see if the software is already installed. If so,
    Severity: Minor
    Found in lib/sprinkle/package.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status